Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fire quorum events until quorum is met for the first time #17074

Merged
merged 1 commit into from Jun 15, 2020

Conversation

mdogan
Copy link
Contributor

@mdogan mdogan commented Jun 12, 2020

Note: Removed data-structure quorum-listeners tests. Quorum events
are not bound to a specific data-structure.

Fixes #17038

3.12.z: #17082

@mdogan mdogan force-pushed the quorum-event-fix-vs branch 2 times, most recently from d56cb06 to 7d278e2 Compare June 12, 2020 11:26
@petrpleshachkov petrpleshachkov self-requested a review June 12, 2020 12:49
Note: Removed data-structure quorum-listeners tests. Quorum events
are not bound to a specific data-structure.
@ghost
Copy link

ghost commented Jun 12, 2020

The job Hazelcast-pr-builder of your PR failed (log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file
--------------------------
-------TEST FAILURE-------
--------------------------
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   CPMemberAutoRemoveTest.when_missingCPNodeJoins_then_itIsNotAutomaticallyRemoved:108->HazelcastTestSupport.assertTrueEventually:1420->HazelcastTestSupport.assertTrueEventually:1318 
Expected: an empty collection
     but: <[CPMember{uuid=1eb9a9c2-9c9f-4547-a711-a86f3d7e38b0, address=[127.0.0.1]:5701}, CPMember{uuid=3a1a002f-1f30-46bb-9498-27a43ba9aacb, address=[127.0.0.1]:5702}]>
[ERROR] Errors: 
[ERROR]   CPMemberAddRemoveTest.when_newCPMemberIsAddedToTheMetadataGroupAfterRestartAndSnapshot_newMemberInstallsSnapshot ? Execution
[INFO] 
[ERROR] Tests run: 14869, Failures: 1, Errors: 1, Skipped: 648
[INFO] 

[ERROR] There are test failures.

@ghost
Copy link

ghost commented Jun 12, 2020

The job Hazelcast-pr-builder of your PR failed (log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file
--------------------------
-------TEST FAILURE-------
--------------------------
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   CPMemberAutoRemoveTest.when_missingCPNodeJoins_then_itIsNotAutomaticallyRemoved:108->HazelcastTestSupport.assertTrueEventually:1420->HazelcastTestSupport.assertTrueEventually:1318 
Expected: an empty collection
     but: <[CPMember{uuid=c2e3228b-ecca-4583-8756-494994fa8772, address=[127.0.0.1]:5702}, CPMember{uuid=789382e1-9e8f-4219-9c61-6a720bbc605d, address=[127.0.0.1]:5701}]>
[ERROR] Errors: 
[ERROR]   CPMemberAddRemoveTest.when_newCPMemberIsAddedToTheMetadataGroupAfterRestart_newMemberCommitsMetadataGroupLogEntries ? Execution
[INFO] 
[ERROR] Tests run: 14869, Failures: 1, Errors: 1, Skipped: 648
[INFO] 

[ERROR] There are test failures.

@mdogan
Copy link
Contributor Author

mdogan commented Jun 12, 2020

Failures in the last two runs, CPMemberAutoRemoveTest and CPMemberAddRemoveTest, are not related to this PR. I checked and tested on 3.12.z branch and they are not failing.

@mmedenjak mmedenjak added this to the 3.12.2-visa4 milestone Jun 15, 2020
@mmedenjak mmedenjak added the Source: Internal PR or issue was opened by an employee label Jun 15, 2020
@hazelcast hazelcast deleted a comment Jun 15, 2020
@hazelcast hazelcast deleted a comment Jun 15, 2020
@hazelcast hazelcast deleted a comment Jun 15, 2020
@mdogan mdogan merged commit 57a4416 into hazelcast:3.12.2-visa4 Jun 15, 2020
@mdogan mdogan deleted the quorum-event-fix-vs branch June 15, 2020 11:10
@hazelcast hazelcast deleted a comment from mdogan Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Source: Internal PR or issue was opened by an employee Team: Core Type: Defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants