Recover exceptions wrapped in same class correctly #17437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to hazelcast#17212 We have added exceptions created by ExceptionUtil.tryWrapInSameClass methods to the client. ClientExceptionFactory.createException method was not handling these exceptions correctly. More specifically, the cause was not set to the exception if there was no Constructor with cause. This pr adds changes to mitigate that. related to hazelcast#17433
ihsandemir
reviewed
Aug 31, 2020
hazelcast/src/main/java/com/hazelcast/client/impl/clientside/ClientExceptionFactory.java
Show resolved
Hide resolved
ihsandemir
approved these changes
Aug 31, 2020
puzpuzpuz
approved these changes
Sep 1, 2020
puzpuzpuz
approved these changes
Sep 1, 2020
| @@ -329,7 +329,11 @@ private Throwable createException(Iterator<ErrorHolder> iterator) { | |||
| if (exceptionFactory == null) { | |||
| throwable = new UndefinedErrorCodeException(errorHolder.getMessage(), errorHolder.getClassName()); | |||
There was a problem hiding this comment.
An off-topic proposal. This branch could be further improved to handle causes for unknown exceptions. See hazelcast/hazelcast-nodejs-client#576 (comment) for more details.
mdumandag
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #17212
We have added exceptions created by ExceptionUtil.tryWrapInSameClass
methods to the client.
ClientExceptionFactory.createException method was not handling these
exceptions correctly. More specifically, the cause was not set to the
exception if there was no Constructor with cause. This pr adds changes
to mitigate that.
related to #17433