Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parallelism=1 in MigrationCommitTest #17451

Merged
merged 1 commit into from Sep 2, 2020

Conversation

mdogan
Copy link
Contributor

@mdogan mdogan commented Sep 2, 2020

Tests were designed for serial migrations. They are already using
2 partitions on 2 data members. Using parallelism=1 will make migrations
serial.

Fixes #14492

Fix in #17445 was incomplete.

Tests were designed for serial migrations. They are already using
2 partitions on 2 data members. Using `parallelism=1` will make migrations
serial.
@ghost
Copy link

ghost commented Sep 2, 2020

The job Hazelcast-pr-builder of your PR failed (log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file
--------------------------
-------TEST FAILURE-------
--------------------------
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   MigrationCorrectnessTest>AbstractMigrationCorrectnessTest.testPartitionData_whenBackupNodesStartedTerminated_withRestart:126->PartitionCorrectnessTestSupport.assertSizeAndDataEventually:221->PartitionCorrectnessTestSupport.assertSizeAndDataEventually:225->HazelcastTestSupport.assertTrueEventually:1350->HazelcastTestSupport.assertTrueEventually:1248->PartitionCorrectnessTestSupport.access$000:66->PartitionCorrectnessTestSupport.assertSizeAndData:269->PartitionCorrectnessTestSupport.assertReplicaVersionsAndBackupValues:333 Replica version mismatch! Owner: [127.0.0.1]:5704, Backup: [127.0.0.1]:5706, Partition: Partition {ID: 40, Version: 25} [
	0:[127.0.0.1]:5704 - 0577e789-e18c-4f52-8d64-a36f92ea6747
	1:[127.0.0.1]:5703 - 13bf2d47-720a-418d-86cb-8c1d59c1c8e9
	2:[127.0.0.1]:5702 - a393d389-122f-46cb-b02c-bd480df41f08
	3:[127.0.0.1]:5706 - 3dacf3c6-3751-4ea6-a9e0-83465bf71998
	4:[127.0.0.1]:5705 - d860d326-710e-44aa-aac8-a21183219124
	5:[127.0.0.1]:5701 - 6b507589-b7cc-49c1-8312-13d7f60018a1
	6:[127.0.0.1]:5707 - 255843a8-4d9c-412f-9c9e-022a3be455e3
], Replica: 3 owner versions: [1, 1, 1, 0, 0, 0] backup versions: [0, 0, 0, 0, 0, 0] expected:<1> but was:<0>
[ERROR]   PostJoinMapOperationTest.testPostJoinMapOperation_mapWithIndex:230->HazelcastTestSupport.assertTrueEventually:1350->HazelcastTestSupport.assertTrueEventually:1248 isIndexed should have located an index expected:<1> but was:<0>
[INFO] 
[ERROR] Tests run: 31485, Failures: 2, Errors: 0, Skipped: 977
[INFO] 

[ERROR] There are test failures.

@mmedenjak mmedenjak added the Source: Internal PR or issue was opened by an employee label Sep 2, 2020
@mdogan
Copy link
Contributor Author

mdogan commented Sep 2, 2020

Unrelated test failures for a trivial test fix. Merging without another PR build.

@mdogan mdogan merged commit e62a7a7 into hazelcast:master Sep 2, 2020
@mdogan mdogan deleted the issue-14492-2 branch September 2, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MigrationCommitTest.shouldCommitMigrationWhenSourceFailsDuringCommit
3 participants