Fixes AbstractInvocationFuture#thenApply #17518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user function is registered on a not-yet complete future, the ApplyNode would not catch an exception thrown from the user function. Now it is caught and completes exceptionally the returned CompletionStage.
| @@ -1065,12 +1163,17 @@ public void acceptEitherAsync() { | |||
| } | |||
|
|
|||
| @Test | |||
| public void applyToEitherAsync_onIncompleteFuture_whenExecutionRejected() { | |||
| public void acceptEither_whenActionThrowsException() { | |||
puzpuzpuz
approved these changes
Sep 11, 2020
ihsandemir
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user function is registered on a not-yet
complete future, the ApplyNode would not catch
an exception thrown from the user function. Now it
is caught and completes exceptionally the returned
CompletionStage.
Also added tests for
DelegatingCompletableFuture'scompletion stage API methods when wrapping
InvocationFutureandInternalCompletableFuture.Fixes #17515 on
master.Backport will follow once this PR is merged