Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize SplitBrainProtectionConfig with valid values #17918

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Initialize SplitBrainProtectionConfig with valid values #17918

merged 1 commit into from
Dec 2, 2020

Conversation

pivovarit
Copy link
Contributor

@pivovarit pivovarit commented Dec 2, 2020 •
edited

When relying on the SplitBrainProtectionConfig constructors, it ends up initialized in an invalid state.

The minimum cluster size configured for split-brain protection can't be lower than 2, but it defaults to 0:

SplitBrainProtectionConfig splitBrainProtectionConfig = new SplitBrainProtectionConfig();
System.out.println(splitBrainProtectionConfig.getMinimumClusterSize()); // 0

Related: #17874

@pivovarit pivovarit added this to the 4.2 milestone Dec 2, 2020
@pivovarit pivovarit marked this pull request as ready for review December 2, 2020 08:45
@pivovarit pivovarit mentioned this pull request Dec 2, 2020
Merged
@pivovarit pivovarit merged commit 0c3bed7 into hazelcast:master Dec 2, 2020
@pivovarit pivovarit deleted the minimal-cluster-size-sb branch December 2, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmedenjak mmedenjak mmedenjak approved these changes

@blazember blazember Awaiting requested review from blazember

Assignees
No one assigned
Labels
Module: Config Source: Internal PR or issue was opened by an employee Team: Core Type: Defect
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pivovarit @mmedenjak