Copy Nearcacheconfig when it needs to be changed #18348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8df8a6e.
sancar
added
Module: Config
Source: Internal
mdumandag
reviewed
Mar 4, 2021
hazelcast/src/test/java/com/hazelcast/config/NearCacheConfigAccessorTest.java
Outdated
Show resolved
Hide resolved
hazelcast/src/test/java/com/hazelcast/config/NearCacheConfigAccessorTest.java
Show resolved
Hide resolved
ahmetmircik
reviewed
Mar 4, 2021
| * Used by the {@link NearCacheConfigAccessor} to | ||
| * initialize the proper default value for on-heap maps. | ||
| */ | ||
| boolean sizeConfigured; |
There was a problem hiding this comment.
if sizeConfigured was set to true, after deserialization what keeps it still true?
There was a problem hiding this comment.
I have reverted the EvictionConfig behaviour. So it seems that setting sizeConfigured on deserialization was not necessary. For the sake of keeping it backward compatible, I will not touch this. Lets consider if that is necessary as a separate fix if needed.
There was a problem hiding this comment.
thanks, i see this is an existing issue, not introduced in this PR. Created an issue for it: #18354
ahmetmircik
reviewed
Mar 4, 2021
hazelcast/src/main/java/com/hazelcast/config/NearCacheConfigAccessor.java
Outdated
Show resolved
Hide resolved
sancar
force-pushed
the
fix/evictionconfig/master
branch
from
a7747a2
to
e5051d2
Compare
Copies NearcacheConfig and EvictionConfig when they needs to be changed by NearcacheConfigAccessor so that the object on ClientConfig/Config does not change when used. fixes hazelcast#17952
ahmetmircik
approved these changes
Mar 4, 2021
mdumandag
approved these changes
Mar 4, 2021
This was referenced Mar 4, 2021
This was referenced Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8df8a6e.
Copies NearcacheConfig and EvictionConfig when they needs
to be changed by NearcacheConfigAccessor so that the object
on ClientConfig/Config does not change when used.
fixes #17952
fixes https://github.com/hazelcast/hazelcast-enterprise/issues/3966