[PLAT-305, API-468] Pretty print cluster connect timeout in logs #18642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default value for the cluster connect timeout is infinite, so it is represented with `Long.MAX_VALUE`. When we try to log this as it is, we output something like below. ``` ... cluster connect timeout: 9223372036854775807 ms, ... ``` To make this more clear, we will replace this with the output below. ``` ... cluster connect timeout: INFINITE, ... ``` If the user has provided some other timeout value (such as 999 ms), the output will still be as it is now. ``` ... cluster connect timeout: 999 ms, ... ```
mdumandag
added
Type: Enhancement
Team: Client
Source: Internal
This was referenced May 6, 2021
sancar
approved these changes
May 6, 2021
|
run-lab-run |
|
unrelated test failure reported on #18644 |
|
run-lab-run |
ihsandemir
approved these changes
May 6, 2021
|
The job Click to expand the log file-------------------------- -------TEST FAILURE------- -------------------------- [INFO] Results: [INFO] [ERROR] Failures: [ERROR] MetricsTest.availableViaJmx:422 name: total not published [INFO] [ERROR] Tests run: 38321, Failures: 1, Errors: 0, Skipped: 995 [INFO] |
|
One more unrelated test failure that is already reported #18626 |
|
run-lab-run |
srknzl
approved these changes
May 6, 2021
degerhz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value for the cluster connect timeout is infinite,
so it is represented with
Long.MAX_VALUE. When we try to logthis as it is, we output something like below.
To make this more clear, we will replace this with the
output below.
If the user has provided some other timeout value (such as 999 ms),
the output will still be as it is now.