Add includeValue support for MultiMap#addLocalEntryListener

[kathapatel]

Enabled includeValue support for Multimap#addLocalEntryListener, implemented listner in MultiMapProxyImpl and ClientMultiMapProxy.

Fixes #18548

Breaking changes (list specific methods/types/messages):

• API
• client protocol format
• serialized form
• snapshot format

Checklist:

• Labels (Team:, Type:, Source:, Module:) and Milestone set
• Add Add to Release Notes label if changes should be mentioned in release notes or Not Release Notes content if changes are not relevant for release notes
• Request reviewers if possible
• New public APIs have @Nonnull/@Nullable annotations
• New public APIs have @since tags in Javadoc
• Send backports/forwardports if fix needs to be applied to past/future releases

[devOpsHazelcast]

Can one of the admins verify this patch?

[devOpsHazelcast]

All committers have signed the CLA.

[kathapatel]

@ihsandemir It's my first PR, could you please help to confirm on remaining 2 items of the checklist?

[gurbuzali]

can you also add tests for the newly added methd, you can take a look at MultiMapListenerTest class

[srknzl]

@kathapatel Regarding checklist, I think this should be added to release notes since a new API is introduced. Also this should be backward and forward ported to other versions. Correct me if I'm wrong @ihsandemir @gurbuzali

[kathapatel]

@srknzl @gurbuzali Do we need to backport/forward port? if so could you please guide me?

[ihsandemir]

@kathapatel Regarding checklist, I think this should be added to release notes since a new API is introduced. Also this should be backward and forward ported to other versions. Correct me if I'm wrong @ihsandemir @gurbuzali

@srknzl This is a new API, hence, I do not think we need any backport.

[ihsandemir]

verify

[Holmistr]

@ihsandemir I see that the requested changes have been addressed. Could you give it another look?

[ahmetmircik]

For the main issue #18548,
I think true behavior was broken at here. True behavior should be including values for local listeners by default in UUID addLocalEntryListener(@Nonnull EntryListener<K, V> listener) method. IMap addLocalEntryListener is also including values by default. So my suggestion is just to restore broken behavior by including values in published events.
BTW, the new method introduced in this PR can also be merged as an enhancement.

WDYT? @ihsandemir @vbekiaris

Update:
Apparently i am wrong to think it was include-value false previously. Thanks @ihsandemir for pointing it.

[ahmetmircik]

LGTM

[ahmetmircik]

run-lab-run

[hz-devops-test]

The job Hazelcast-pr-builder of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file

--------------------------
-------TEST FAILURE-------
--------------------------
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   PartitionIndexingTest.testOnProgrammaticallyAddedIndexes:168->assertPartitionsIndexedCorrectly:220 map_hash_this is missing 2 partitions expected:<101> but was:<99>
[INFO] 
[ERROR] Tests run: 46696, Failures: 1, Errors: 0, Skipped: 1015
[INFO] 
[ERROR] There are test failures.

[ahmetmircik]

run-lab-run

[ahmetmircik]

@kathapatel thanks for the contribution.