Fixes SplitBrainTest start issues #19180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SplitBrainStatus is set by a single thread at the hazelcast instance start in an async manner. Therefore, we are not sure that a the status is set when the test starts. Adding an eventually check at the start so that we make sure we have the min-size cluster for all split brain protections before we actually split the cluster fixes hazelcast#18950 fixes hazelcast#18777 fixes hazelcast#18766 fixes hazelcast#18765 fixes hazelcast#18764 fixes hazelcast#18930
sancar
added
Team: Client
Team: Core
Type: Test-Failure
Source: Internal
mmedenjak
approved these changes
Jul 26, 2021
This was referenced Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SplitBrainStatus is set by a single thread at the hazelcast instance
start in an async manner. Therefore, we are not sure that a the
status is set when the test starts.
Adding an eventually check at the start so that we make sure we
have the min-size cluster for all split brain protections before
we actually split the cluster
fixes #18950
fixes #18777
fixes #18766
fixes #18765
fixes #18764
fixes #18930