[HZ-561] Implement EXISTS and NOT EXISTS expressions #19729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakanmemisoglu
added
Type: Enhancement
Source: Internal
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gierlachg
reviewed
Oct 7, 2021
hazelcast-sql/src/main/java/com/hazelcast/jet/sql/impl/HazelcastSqlToRelConverter.java
Outdated
Show resolved
Hide resolved
hazelcast-sql/src/main/java/com/hazelcast/jet/sql/impl/opt/physical/CreateDagVisitor.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
gierlachg
reviewed
Oct 13, 2021
hazelcast-sql/src/main/java/com/hazelcast/jet/sql/impl/aggregate/ObjectArrayKey.java
Show resolved
Hide resolved
hazelcast-sql/src/main/java/com/hazelcast/jet/sql/impl/opt/physical/CreateDagVisitor.java
Outdated
Show resolved
Hide resolved
hazelcast-sql/src/main/java/com/hazelcast/jet/sql/impl/opt/physical/JoinConverterRule.java
Outdated
Show resolved
Hide resolved
AyberkSorgun
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gierlachg
reviewed
Oct 20, 2021
hazelcast-sql/src/main/java/com/hazelcast/jet/sql/impl/parse/QueryConverter.java
Outdated
Show resolved
Hide resolved
hazelcast-sql/src/main/java/com/hazelcast/jet/sql/impl/processors/HashJoinProcessor.java
Outdated
Show resolved
Hide resolved
...in/java/com/hazelcast/jet/sql/impl/validate/operators/predicate/HazelcastExistsOperator.java
Outdated
Show resolved
Hide resolved
gierlachg
reviewed
Oct 20, 2021
| @@ -93,6 +93,11 @@ public void consume(Inbox inbox) { | |||
| offset--; | |||
| } | |||
|
|
|||
| if (limit <= 0) { | |||
There was a problem hiding this comment.
Why is it needed? All tests pass without it.
There was a problem hiding this comment.
It was needed for the previous implementation because it was breaking LIMIT 0 queries in other SQL tests.
Interestingly, it works now. I am planning to keep it because if limit == 0, then the logic in the consume is wrong.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
* Remove assertions * Use kind equality directly * Improve operator operand count and type checks
This comment has been minimized.
This comment has been minimized.
|
run-lab-run |
gierlachg
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of
EXISTS(...)andNOT EXISTS(...)expressions for SQLNOTE:
This implementation has different visibility semantics for the rows originated from right input.