-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HZ-566] SQL: CREATE INDEX implementation #19810
Conversation
c400ed6
to
46d247f
Compare
7fe140a
to
dbae6f0
Compare
dbae6f0
to
4900038
Compare
} | ||
|
||
@Test | ||
public void indexArgsCannotBeDuplicatedTest() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't test duplicate options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For map.addIndex(IndexType.SORTED, "this", "this");
:
java.lang.IllegalArgumentException: Duplicate attribute name [attributeName=this, indexConfig=IndexConfig{name=null, type=SORTED, attributes=[this, this]}]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It means, both test and check are makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean duplicate OPTIONS, not attributes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry. You pointed to indexArgsCannotBeDuplicatedTest(), and I immediately switched to args context :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always add comments to some code line. Comments added to the whole PR cannot be marked as resolved.
hazelcast-sql/src/main/java/com/hazelcast/jet/sql/impl/SqlPlanImpl.java
Outdated
Show resolved
Hide resolved
hazelcast-sql/src/test/java/com/hazelcast/jet/sql/impl/parse/HazelcastSqlParserTest.java
Outdated
Show resolved
Hide resolved
hazelcast-sql/src/test/java/com/hazelcast/jet/sql/SqlCreateIndexTest.java
Outdated
Show resolved
Hide resolved
…for existing index + IF NOT EXISTS in the next query, add new permission for index creation
89ea255
to
a7fedd9
Compare
Co-authored-by: Viliam Durina <viliam@hazelcast.com>
CREATE INDEX
was fully implemented.Grammar :
Options are available only for BITMAP index since it has additional
BitmapIndexConfig
. Those options are supported:unique_key
unique_key_transformation
.In case of SORTED/HASH index, options usage causes
QueryException
.DROP INDEX
syntax was supported, but not the execution path (DROP INDEX
query throwsUnsupportedException
).Checklist:
Team:
,Type:
,Source:
,Module:
) and Milestone setAdd to Release Notes
orNot Release Notes content
set