Make HazelcastJsonValue work with PagingPredicate #19880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sancar
added
Type: Defect
Team: Client
Team: Core
Source: Internal
srknzl
approved these changes
Nov 1, 2021
| @@ -35,7 +37,7 @@ | |||
| * Ill-formatted JSON strings may cause false positive or false negative | |||
| * results in queries. {@code null} string is not allowed. | |||
| */ | |||
| public final class HazelcastJsonValue { | |||
| public final class HazelcastJsonValue implements Comparable<HazelcastJsonValue> { | |||
There was a problem hiding this comment.
With this change all languages that has HazelcastJsonValue will be able use PagingPredicate with HazelcastJsonValue, is it right?
|
I think it might be good to have some ideas regarding this from the SQL team as well. @ivanthescientist can you comment on this? |
|
I don't think this will affect SQL in any way. Every operation related to JSON will extract String value first anyway. |
ihsandemir
approved these changes
Nov 1, 2021
HazelcastJsonValue is made Comparable to work with PagingPredicate fixes hazelcast#14888
sancar
force-pushed
the
fix/pagingJson/master
branch
from
24ab7f5
to
072f00c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HazelcastJsonValue is made Comparable to work with PagingPredicate
fixes #14888