Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HZ-713] Chunked migration #20005

Merged
merged 3 commits into from
Jan 10, 2022
Merged

[HZ-713] Chunked migration #20005

merged 3 commits into from
Jan 10, 2022

Conversation

ahmetmircik
Copy link
Member

@ahmetmircik ahmetmircik commented Dec 1, 2021 •
edited
Loading

@ahmetmircik ahmetmircik added this to the 5.1 milestone Dec 1, 2021
@ahmetmircik ahmetmircik changed the title [WIP] Chunked migration [HZ-713] [WIP] Chunked migration Dec 1, 2021
@ahmetmircik ahmetmircik mentioned this pull request Dec 1, 2021
Closed
@hazelcast hazelcast deleted a comment from hz-devops-test Dec 1, 2021
@ahmetmircik ahmetmircik marked this pull request as ready for review December 2, 2021 10:54
@ahmetmircik ahmetmircik force-pushed the feature/5.1/chunkedMigration branch 4 times, most recently from 61e45d3 to cba84c0 Compare December 10, 2021 14:30
@ahmetmircik ahmetmircik force-pushed the feature/5.1/chunkedMigration branch 6 times, most recently from 4758f1f to 3133d13 Compare December 20, 2021 15:10
@ahmetmircik ahmetmircik force-pushed the feature/5.1/chunkedMigration branch 3 times, most recently from 25fd5ad to e6e7bc3 Compare December 27, 2021 07:52
@ahmetmircik ahmetmircik changed the title [HZ-713] [WIP] Chunked migration [HZ-713] Chunked migration Dec 27, 2021
@ahmetmircik ahmetmircik force-pushed the feature/5.1/chunkedMigration branch 2 times, most recently from e1323ec to 13ade5c Compare January 4, 2022 07:30
@hazelcast hazelcast deleted a comment from hz-devops-test Jan 5, 2022
@hazelcast hazelcast deleted a comment from hz-devops-test Jan 5, 2022
@hazelcast hazelcast deleted a comment from hz-devops-test Jan 5, 2022
vbekiaris
vbekiaris reviewed Jan 6, 2022
View reviewed changes
Copy link
Contributor

@vbekiaris vbekiaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, a minor change is required in MigrationManager to deal properly with cluster version.

hazelcast/src/main/java/com/hazelcast/internal/partition/ChunkSerDerHelper.java Outdated Show resolved Hide resolved
hazelcast/src/main/java/com/hazelcast/internal/partition/ChunkSerDerHelper.java Outdated Show resolved Hide resolved
hazelcast/src/main/java/com/hazelcast/internal/partition/impl/MigrationManager.java Outdated Show resolved Hide resolved
...ast/src/main/java/com/hazelcast/internal/partition/operation/AbstractPartitionOperation.java Outdated Show resolved Hide resolved
hazelcast/src/test/resources/log4j2.xml Outdated Show resolved Hide resolved
...ast/src/main/java/com/hazelcast/internal/partition/operation/AbstractPartitionOperation.java Outdated Show resolved Hide resolved
...ast/src/main/java/com/hazelcast/internal/partition/operation/AbstractPartitionOperation.java Outdated Show resolved Hide resolved
hazelcast/src/main/java/com/hazelcast/map/impl/operation/MapChunk.java Outdated Show resolved Hide resolved
hazelcast/src/main/java/com/hazelcast/map/impl/operation/MapChunk.java Outdated Show resolved Hide resolved
@hz-devops-test
Copy link

The job Hazelcast-pr-builder of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file 
--------------------------
---------SUMMARY----------
--------------------------
[ERROR] Failed to execute goal org.codehaus.mojo:license-maven-plugin:2.0.0:add-third-party (add-third-party) on project hazelcast-build-utils: could not init goal AddThirdPartyMojo for reason : null: NoSuchElementException -> [Help 1]
--------------------------

@ahmetmircik
Copy link
Member Author

run-lab-run

fbarotov
fbarotov approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@fbarotov fbarotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

ahmetmircik and others added 2 commits January 10, 2022 14:36
@ahmetmircik ahmetmircik merged commit a1adfa2 into hazelcast:master Jan 10, 2022
@ahmetmircik ahmetmircik deleted the feature/5.1/chunkedMigration branch January 10, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbarotov fbarotov fbarotov approved these changes

@vbekiaris vbekiaris vbekiaris approved these changes

Assignees
No one assigned
Labels
Add to Release Notes Module: Partitioning Source: Internal PR or issue was opened by an employee Team: Core Type: Enhancement
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ahmetmircik @hz-devops-test @vbekiaris @fbarotov @mmedenjak