Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HZ-581] Address issues with hostnames #20014

Merged
merged 86 commits into from Jan 11, 2022
Merged

[HZ-581] Address issues with hostnames #20014

merged 86 commits into from Jan 11, 2022

Commits on Nov 30, 2021

  1. WIP - Handle TcpServerConnections with UUID

    Ufuk Yılmaz committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    4a05f70 View commit details
    Browse the repository at this point in the history

  2. WIP - Adjust test classes

    Ufuk Yılmaz committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    f8595d3 View commit details
    Browse the repository at this point in the history

  3. WIP

    Ufuk Yılmaz committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    0215da4 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2021

  1. Update the Node#thisUuid in cluster service reset

    Ufuk Yılmaz committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    3f43451 View commit details
    Browse the repository at this point in the history

  2. Do more proper null handling in mock network classes

    Ufuk Yılmaz committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    40bcf59 View commit details
    Browse the repository at this point in the history

  3. Tidy up handshake processing

    Ufuk Yılmaz committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    fbcaf94 View commit details
    Browse the repository at this point in the history

  4. Add member uuid into MockServerContext

    Ufuk Yılmaz committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    898209b View commit details
    Browse the repository at this point in the history

  5. Register/deregister address-uuid entries upon membership changes

    Ufuk Yılmaz committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    46f5afd View commit details
    Browse the repository at this point in the history

  6. Small cleanup

    Ufuk Yılmaz committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    f5820d9 View commit details
    Browse the repository at this point in the history

  7. Fix style

    Ufuk Yılmaz committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    c3d74a6 View commit details
    Browse the repository at this point in the history

  8. Tidy up LinkedAddresses and LocalAddressRegistry

    Ufuk Yılmaz committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    f48d286 View commit details
    Browse the repository at this point in the history

  9. Handle uuid-address registration for the client connections

    Ufuk Yılmaz committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    e384c90 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2021

  1. Fix style

    Ufuk Yılmaz committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    8c60b97 View commit details
    Browse the repository at this point in the history

  2. Cleanup

    Ufuk Yılmaz committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    3232a1e View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2021

  1. Reflect the changes to TcpServerControlTest

    Ufuk Yılmaz committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    c8b0256 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2021

  1. Remove address registration stuff from MembershipManager

    Ufuk Yılmaz committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    d60fd90 View commit details
    Browse the repository at this point in the history

  2. Fix style

    Ufuk Yılmaz committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    1dc1127 View commit details
    Browse the repository at this point in the history

  3. Reset address registry on split-brain-merge

    @vbekiaris
    vbekiaris committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    c67a0f3 View commit details
    Browse the repository at this point in the history

  4. Change the address registry removal timing 

    Now, we remove the address registry entries when all connections (on all
planes) belonging to the same instance are closed.
    Ufuk Yılmaz committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    8b31af4 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2021

  1. Handle duplicate connections between members 

    Now, we're closing the connection whose acceptor side has smaller member uuid. In
this manner, we can assume some ordering between these duplicate connections and
deterministically close only one of them.

Fixes hazelcast#18877, hazelcast#19767
    Ufuk Yılmaz committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    3f00596 View commit details
    Browse the repository at this point in the history

  2. Fix style

    Ufuk Yılmaz committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    940b8c3 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2021

  1. Add some tests for address registry

    Ufuk Yılmaz committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    3b35445 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2021

  1. Enhance TcpServerControlTest

    Ufuk Yılmaz committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    226bb0f View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2021

  1. Add javadoc and more tests to the address registry

    Ufuk Yılmaz committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    34987a2 View commit details
    Browse the repository at this point in the history

  2. Add tests

    Ufuk Yılmaz committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    601c02b View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2021

  1. Add local member's addresses to the address registry 

    Also, changed entry override during the register a bit, now the entry
removal from the registry not only depends on a key (address in this
case). Now, I remove the entries that match both old uuid and old
addresses.
    Ufuk Yılmaz committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    dcbe5ae View commit details
    Browse the repository at this point in the history

  2. Use public address as a primary address in any case

    Ufuk Yılmaz committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    3800be9 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2021

  1. Do address registrations in ConnectionManager#register 

    Making sure registering these addresses before removing connections
from in progress set.
    Ufuk Yılmaz committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    88ba1ce View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into 5.1/hostname-fix-… 

    …part-1
    Ufuk Yılmaz committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    57a2eba View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2021

  1. Remove LocalAddressRegistry#getPrimaryAddress(Address) 

    Since it may have problems in terms of consistency, removed it.
    Ufuk Yılmaz committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    4e24b37 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2021

  1. Perform address registration in MockNetwork

    Ufuk Yılmaz committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    7aa1f7a View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2021

  1. Add all local addresses to address registry

    Ufuk Yılmaz committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    20152e1 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into 5.1/hostname-fix-… 

    …part-1
    Ufuk Yılmaz committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    5e9e2da View commit details
    Browse the repository at this point in the history

  3. Handle local addresses separately in LocalAddressRegistry

    Ufuk Yılmaz committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    33cdc0f View commit details
    Browse the repository at this point in the history

  4. Fix shouldConnectTo

    Ufuk Yılmaz committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    815e993 View commit details
    Browse the repository at this point in the history

  5. Fix up Handle local addresses separately in LocalAddressRegistry

    Ufuk Yılmaz committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    fa5af7f View commit details
    Browse the repository at this point in the history

  6. Fix NPE in mock tests

    Ufuk Yılmaz committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    20c2b73 View commit details
    Browse the repository at this point in the history

  7. Resolve the given address before perform lookup

    Ufuk Yılmaz committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    dcdd5bb View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2021

  1. Add javadocs to address picker methods

    Ufuk Yılmaz committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    4d09104 View commit details
    Browse the repository at this point in the history

  2. Give explicit priority to the member protocol public address in addre… 

    …ss registration

Also, performed small adjustment in local address registration
    Ufuk Yılmaz committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    7382ecc View commit details
    Browse the repository at this point in the history

  3. Fix TcpIpJoiner#isLocalAddress

    Ufuk Yılmaz committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    ab3b931 View commit details
    Browse the repository at this point in the history

  4. Improve logging on blacklist

    Ufuk Yılmaz committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    828d47a View commit details
    Browse the repository at this point in the history

  5. Handle blacklisted addresses in ClusterMismatchOp

    Ufuk Yılmaz committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    e114bb1 View commit details
    Browse the repository at this point in the history

  6. Fix style

    Ufuk Yılmaz committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    7d20c8c View commit details
    Browse the repository at this point in the history

  7. Fix local address registration issue

    Ufuk Yılmaz committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    70c7370 View commit details
    Browse the repository at this point in the history

  8. Add TcpIpHostnameJoinTest

    Ufuk Yılmaz committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    6070012 View commit details
    Browse the repository at this point in the history

  9. Add trace logs to hostname join tests

    Ufuk Yılmaz committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    5134a4e View commit details
    Browse the repository at this point in the history

  10. Add null check to serverSocketChannel access

    Ufuk Yılmaz committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    da4ca54 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2021

  1. Try not to lose targetAddress of the connection

    Ufuk Yılmaz committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    b9ba29d View commit details
    Browse the repository at this point in the history

  2. Address part of the reviews

    Ufuk Yılmaz committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    a604e91 View commit details
    Browse the repository at this point in the history

  3. Add null check to registered target address

    Ufuk Yılmaz committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    03106c8 View commit details
    Browse the repository at this point in the history

  4. Handle duplicate connections after addresses registered

    Ufuk Yılmaz committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    4db748c View commit details
    Browse the repository at this point in the history

  5. Fix isThisNodeMasterCandidate

    Ufuk Yılmaz committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    dff3925 View commit details
    Browse the repository at this point in the history

  6. Fix style

    Ufuk Yılmaz committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    a06d690 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2021

  1. Adjust the address registry logs

    Ufuk Yılmaz committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    ace549c View commit details
    Browse the repository at this point in the history

  2. Fix tests that include mock logger

    Ufuk Yılmaz committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    6169f11 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2021

  1. Remove reverse DNS lookup from address resolution

    Ufuk Yılmaz committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    8044273 View commit details
    Browse the repository at this point in the history

  2. Fix any local address check 

    Also, skipped the virtual and not running NIC while registering
local addresses.
    Ufuk Yılmaz committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    6339821 View commit details
    Browse the repository at this point in the history

  3. Make Node#thisUuid private 

    Also, added nullable and nonnull annotations to public APIs.
    Ufuk Yılmaz committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    928e681 View commit details
    Browse the repository at this point in the history

  4. Fix minor issues

    Ufuk Yılmaz committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    1c45ac9 View commit details
    Browse the repository at this point in the history

  5. Remove ip address resolution from hot path

    Ufuk Yılmaz committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    2855d25 View commit details
    Browse the repository at this point in the history

  6. Improve the javadocs of ServerConnectionManager

    Ufuk Yılmaz committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    a2ac119 View commit details
    Browse the repository at this point in the history

  7. Do not skip any network interfaces

    Ufuk Yılmaz committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    a65d437 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2021

  1. Try to handle self connections

    Ufuk Yılmaz committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    e142559 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into 5.1/hostname-fix-… 

    …part-1
    Ufuk Yılmaz committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    b5bbbbf View commit details
    Browse the repository at this point in the history

  3. Handle self connections second attempt

    Ufuk Yılmaz committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    9856887 View commit details
    Browse the repository at this point in the history

  4. Handle error cases inside connection registration

    Ufuk Yılmaz committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    c36a8fa View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2022

  1. Revert unnecessary change on join

    Ufuk Yılmaz committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    e369dff View commit details
    Browse the repository at this point in the history

  2. Refactor connection manager

    Ufuk Yılmaz committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    8910935 View commit details
    Browse the repository at this point in the history

  3. Address parts of the review 

    Encapsulated get connections on all planes mechanism into a method in
ServerConnectionManager, then removed uuid based methods from the
public interface.
    Ufuk Yılmaz committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    71c6482 View commit details
    Browse the repository at this point in the history

  4. fixup! Address parts of the review

    Ufuk Yılmaz committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    55d88e7 View commit details
    Browse the repository at this point in the history

  5. Reduce the number of hostname->ip resolutions

    Ufuk Yılmaz committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    dd70a03 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2022

  1. Remove synchronized block from removeConnectionInProgress

    Ufuk Yılmaz committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    7f3153f View commit details
    Browse the repository at this point in the history

  2. Fixup

    Ufuk Yılmaz committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    95aae26 View commit details
    Browse the repository at this point in the history

  3. Fix npe in mock server

    Ufuk Yılmaz committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    6e0fd77 View commit details
    Browse the repository at this point in the history

  4. Remove stale todo item

    Ufuk Yılmaz committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    6919437 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2022

  1. Capture remove connection in progress into synchronized block

    Ufuk Yılmaz committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    28e10c4 View commit details
    Browse the repository at this point in the history

  2. Improve duplicate connection handling

    Ufuk Yılmaz committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    ea1ead2 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. Fix TcpIpJoiner#searchForOtherClusters

    Ufuk Yılmaz committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    f508686 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2022

  1. Merge remote-tracking branch 'upstream/master' into 5.1/hostname-fix-… 

    …part-1
    Ufuk Yılmaz committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    2d28144 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2022

  1. Revert connection in progress handling 

    Since, it creates so much complexity without much gain.
    Ufuk Yılmaz committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    aff02d3 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2022

  1. Remove duplicate connections handling 

    Because if we close this connection after it starts to be used from one
side, we lose some packets on the way.
    Ufuk Yılmaz committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    5f5c6c3 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into 5.1/hostname-fix-… 

    …part-1

# Conflicts:
#	hazelcast/src/test/java/com/hazelcast/instance/TestNodeContext.java
    Ufuk Yılmaz committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    a068eb6 View commit details
    Browse the repository at this point in the history

  3. Remove one unnecessary LocalAddressRegistry#uuidOf call

    Ufuk Yılmaz committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    0b0caad View commit details
    Browse the repository at this point in the history

  4. Adapt address registry integration test to duplicate conns 

    Formerly, the tests were assuming that there is only one
connection on each plane between the members. So, tests
started to fail when we remove duplicate handling.
    Ufuk Yılmaz committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    6825d69 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Merge remote-tracking branch 'upstream/master' into 5.1/hostname-fix-… 

    …part-1
    Ufuk Yılmaz committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    1860672 View commit details
    Browse the repository at this point in the history