Define declarative configuration schemas for CompactSerializationConfig #20016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR defines XSD and JSON schema for the CompactSerializationConfig so that it can be used without disabling schema validation. This PR is created on top of hazelcast#19276, and contains the other changes required in the configuration change checklist we have.
mdumandag
added
Type: Enhancement
Team: Client
Source: Internal
|
The job Click to expand the log file-------------------------- ---------SUMMARY---------- -------------------------- [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:checkstyle (default) on project hazelcast: An error has occurred in Checkstyle report generation. Failed during checkstyle execution: There are 18 errors reported by Checkstyle 8.38 with /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/checkstyle/checkstyle.xml ruleset. -> [Help 1] -------------------------- ---------ERRORS----------- -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/main/java/com/hazelcast/client/config/ClientConfigXmlGenerator.java:308: Line is longer than 130 characters (found 154). [LineLength] -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/main/java/com/hazelcast/client/config/ClientConfigXmlGenerator.java:671: Line is longer than 130 characters (found 135). [LineLength] -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/main/java/com/hazelcast/client/config/ClientConfigXmlGenerator.java:689: Line is longer than 130 characters (found 135). [LineLength] -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/main/java/com/hazelcast/config/ConfigXmlGenerator.java:489:5: Cyclomatic Complexity is 15 (max allowed is 12). [CyclomaticComplexity] -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/main/java/com/hazelcast/config/ConfigXmlGenerator.java:489:5: Method length is 71 lines (max allowed is 60). [MethodLength] -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/main/java/com/hazelcast/config/ConfigXmlGenerator.java:554: Line is longer than 130 characters (found 154). [LineLength] -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/main/java/com/hazelcast/config/ConfigXmlGenerator.java:1879: Line is longer than 130 characters (found 135). [LineLength] -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/main/java/com/hazelcast/config/ConfigXmlGenerator.java:1897: Line is longer than 130 characters (found 135). [LineLength] -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/client/config/ClientConfigXmlGeneratorTest.java:25:8: Unused import - com.hazelcast.config.Config. [UnusedImports] -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/config/AbstractConfigBuilderTest.java:21:8: Unused import - com.hazelcast.internal.serialization.Data. [UnusedImports] -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/config/AbstractConfigBuilderTest.java:22:8: Unused import - com.hazelcast.internal.serialization.SerializationService. [UnusedImports] -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/config/AbstractConfigBuilderTest.java:23:8: Unused import - com.hazelcast.internal.serialization.impl.DefaultSerializationServiceBuilder. [UnusedImports] -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/config/AbstractConfigBuilderTest.java:24:8: Unused import - com.hazelcast.internal.serialization.impl.compact.CompactTestUtil. [UnusedImports] -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/config/AbstractConfigBuilderTest.java:26:8: Unused import - example.serialization.EmployeeDTO. [UnusedImports] -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/config/AbstractConfigBuilderTest.java:27:8: Unused import - example.serialization.ExternalizableEmployeeDTO. [UnusedImports] -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/config/XMLConfigBuilderTest.java:20:8: Unused import - com.hazelcast.client.config.ClientConfig. [UnusedImports] -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/config/XMLConfigBuilderTest.java:67:15: Unused import - com.hazelcast.config.ConfigRecognizerTest.HAZELCAST_CLIENT_END_TAG. [UnusedImports] -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/config/XMLConfigBuilderTest.java:68:15: Unused import - com.hazelcast.config.ConfigRecognizerTest.HAZELCAST_CLIENT_START_TAG. [UnusedImports] -------------------------- |
sancar
approved these changes
Dec 2, 2021
zpqrtbnk
approved these changes
Dec 7, 2021
|
@frant-hartm I am going to merge this PR, as it was waiting for quite a long time. If you still want to review it afterward, please do it, and I will create a separate PR to fix your review comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines XSD and JSON schema for the CompactSerializationConfig
so that it can be used without disabling schema validation.
This PR is created on top of #19276, and contains the other changes
required in the configuration change checklist we have.