[HZ-771] Align query-cache and near-cache default behavior #20265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmetmircik
force-pushed
the
fix/5.1/QC_and_NC
branch
2 times, most recently
from
81bdcb5
to
8aa400b
Compare
ahmetmircik
changed the title
ahmetmircik
force-pushed
the
fix/5.1/QC_and_NC
branch
2 times, most recently
from
96c9bad
to
1adbb38
Compare
ahmetmircik
force-pushed
the
fix/5.1/QC_and_NC
branch
from
1adbb38
to
96a4656
Compare
ahmetmircik
force-pushed
the
fix/5.1/QC_and_NC
branch
4 times, most recently
from
9fa68ca
to
96af0ca
Compare
ahmetmircik
force-pushed
the
fix/5.1/QC_and_NC
branch
3 times, most recently
from
b9b2f72
to
048b8e6
Compare
mmedenjak
added
Module: IMap
Module: Near Cache
Source: Internal
ahmetmircik
force-pushed
the
fix/5.1/QC_and_NC
branch
2 times, most recently
from
8f04a7c
to
cb376dc
Compare
|
run-lab-run |
ahmetmircik
force-pushed
the
fix/5.1/QC_and_NC
branch
4 times, most recently
from
ca625d8
to
84e5597
Compare
ramizdundar
reviewed
Jan 13, 2022
hazelcast/src/main/java/com/hazelcast/internal/config/dynamic/DynamicConfigXmlGenerator.java
Show resolved
Hide resolved
...t/src/main/java/com/hazelcast/map/impl/querycache/subscriber/AbstractInternalQueryCache.java
Show resolved
Hide resolved
Comment on lines
+263
to
267
| if (areKeyValueObjectType) { | ||
| queryEntry.initWithObjectKeyValue(queryCacheKey, rawValue); | ||
| } else { | ||
| queryEntry.init(queryCacheKey, rawValue); | ||
| } |
There was a problem hiding this comment.
I fail to understand the difference here. What would happen if we were to only call queryEntry.init(queryCacheKey, rawValue); instead of this if else block?
There was a problem hiding this comment.
Good catch, it is an optimization and JMH shows it made some difference positively.initWithObjectKeyValue has no checks in it.
There was a problem hiding this comment.
Ah, thanks, can you leave a small comment for this then. This way someone like me wouldn't simplify it accidentally.
There was a problem hiding this comment.
actually i already did it at the start of method:
// needed for optimization where key and value are not an instance of Data type
final boolean areKeyValueObjectType = !queryCacheConfig.isSerializeKeys()
&& InMemoryFormat.OBJECT == queryCacheConfig.getInMemoryFormat();
...t/src/main/java/com/hazelcast/map/impl/querycache/subscriber/AbstractInternalQueryCache.java
Show resolved
Hide resolved
hazelcast/src/test/java/com/hazelcast/map/impl/querycache/QueryCacheBenchmark.java
Show resolved
Hide resolved
ahmetmircik
force-pushed
the
fix/5.1/QC_and_NC
branch
from
84e5597
to
b404c31
Compare
|
The job Click to expand the log file-------------------------- -------TEST FAILURE------- -------------------------- [INFO] Results: [INFO] [ERROR] Errors: [ERROR] YamlConfigBuilderTest.testQueryCacheFullConfig:2718->buildConfig:1843 ? SchemaViolationConfiguration [INFO] [ERROR] Tests run: 46689, Failures: 0, Errors: 1, Skipped: 1015 [INFO] |
ahmetmircik
force-pushed
the
fix/5.1/QC_and_NC
branch
from
b404c31
to
8ac584c
Compare
ramizdundar
approved these changes
Jan 14, 2022
sancar
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19487
Modifications
QueryCacheto eliminate extra deserialization whenOBJECTin memory format is used.serializeKeysflag toQueryCacheConfigto align behavior withNearCacheDocs:
hazelcast/hz-docs#353
Client Protocol Changes: hazelcast/hazelcast-client-protocol#407
Benchmarks
Simulator
test file: hazelcast/hazelcast-simulator#1972
ThisPR(red) vs 5.0.z(blue)
Comparison of
QueryCache#valuesthroughputJMH
5.0.z
ThisPR