[HZ-707] HOP window function support #20342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # hazelcast-sql/src/main/java/com/hazelcast/jet/sql/impl/OptimizerContext.java
mmedenjak
added
Source: Internal
Fly-Style
force-pushed
the
vilo-hop-aggregation
branch
from
1bc32c0
to
4094442
Compare
Fly-Style
force-pushed
the
vilo-hop-aggregation
branch
from
297a247
to
c9603e4
Compare
viliam-durina
approved these changes
Jan 25, 2022
ivanthescientist
approved these changes
Jan 26, 2022
| @@ -42,7 +42,7 @@ | |||
| }; | |||
|
|
|||
| public ImposeOrderFunction() { | |||
| super("IMPOSE_ORDER", new WindowOperandMetadata(PARAMETERS), RETURN_TYPE_INFERENCE); | |||
| super("IMPOSE_ORDER", new WindowOperandMetadata(PARAMETERS, new int[]{2}), RETURN_TYPE_INFERENCE); | |||
There was a problem hiding this comment.
Think the new int[]{2} bit needs a comment with explanation. Or better yet a constant.
There was a problem hiding this comment.
The argument taking this value is documented...
| @Override | ||
| public Void visitInputRef(RexInputRef inputRef) { | ||
| if (arrayIndexOf(inputRef.getIndex(), indexes) >= 0) { | ||
| res[0] = true; |
There was a problem hiding this comment.
Any reason this has to be an array? Just checking.
There was a problem hiding this comment.
@ivanthescientist outer variable should be effective final to be accessible within the anonymous class/lambda context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Team:,Type:,Source:,Module:) and Milestone setAdd to Release NotesorNot Release Notes contentsetAlso, fixes #19943