Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.1-BETA-1] Revert "[HZ-581] Address issues with hostnames (#20014)" #20353

Closed
wants to merge 1 commit into from
Closed

[5.1-BETA-1] Revert "[HZ-581] Address issues with hostnames (#20014)" #20353

wants to merge 1 commit into from

Conversation

ufukyilmaz
Copy link
Contributor

@ufukyilmaz ufukyilmaz commented Jan 12, 2022 •
edited

This PR reverts the changes of #20014, since some problems occur on the enterprise
side with mock test classes.

Checklist:

  • Labels (Team:, Type:, Source:, Module:) and Milestone set
  • Label Add to Release Notes or Not Release Notes content set
  • Request reviewers if possible
  • Send backports/forwardports if fix needs to be applied to past/future releases
  • New public APIs have @Nonnull/@Nullable annotations
  • New public APIs have @since tags in Javadoc

@ufukyilmaz ufukyilmaz added this to the 5.1 milestone Jan 12, 2022
@ufukyilmaz ufukyilmaz requested a review from a team as a code owner January 12, 2022 13:11
@ufukyilmaz ufukyilmaz self-assigned this Jan 12, 2022
ramizdundar
ramizdundar approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@ramizdundar ramizdundar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:**

@ufukyilmaz ufukyilmaz closed this Jan 12, 2022
@mmedenjak mmedenjak added Module: Network I/O Source: Internal PR or issue was opened by an employee Team: Core labels Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramizdundar ramizdundar ramizdundar approved these changes

@vbekiaris vbekiaris Awaiting requested review from vbekiaris

Assignees

@ufukyilmaz ufukyilmaz

Labels
Module: Network I/O Source: Internal PR or issue was opened by an employee Team: Core Type: Defect
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ufukyilmaz @ramizdundar @mmedenjak