Backport hz start to 5.0.z
#20812
Merged
Backport hz start to 5.0.z
#20812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…20262) * Add hz to distribution package HZ-625 * Remove not used classpath elements from hz script HZ-625 * Usage HAZELCAST_CONFIG in hz HZ-625 * Use prometheus version from variable HZ-625 * Checkstyle fix HZ-625 * Remove mc subcommand HZ-625 * Use BuildInfoProvider for getting hz version HZ-625 * Remove not used resources HZ-625 * Use hz-stop to stop instances started by hz command HZ-625 * Add option to hz command to run Hazelcast instance as daemon HZ-625 * Delegate "hz-start" to "hz start" HZ-625 * Update distribution/src/test/java/com/hazelcast/distribution/DistributionIT.java Co-authored-by: František Hartman <frant.hartm@gmail.com> * Inline AbstractCommandLine * Suppress output in daemon mode * Remove redundant config loader * Use standard system properties for setting port and interface in hz command * Rename HazelcastCommandLine to HazelcastServerCommandLine * Use HazelcastMemberStarter to start the instance * Use nohup for daemon mode in hz command * Simplify finding script location in hz * Simplify CLASSPATH in hz * Print always java details when running hz * Revert "Use hz-stop to stop instances started by hz command HZ-625" This reverts commit ff6daa6. * Replace workingdirectory property with HAZELCAST_HOME env * Remove Runnable interface from HazelcastServerCommandLine * Remove unused resource file * Cleanup logging in hz command
The Hazelcast process wasn't being killed correctly and in combination with java.lang.ProcessBuilder#inheritIO the JVM running the test was hanging at shut down (the test passed correctly). There were 2 issues causing improper shutdown: - the scripts hz/hz-start were not using exec command which replaces current shell process with the command, this resulted in killing the shell, but that doesn't immediatelly kill the HazelcastServerCommandLine process. Using exec means we kill the HazelcastServerCommandLine directly. - similarly the HazelcastServerCommandLine starts a new process (HazelcastMemberStarter) and when it is killed it doesn't automatically kill the new process. Added shutdown hook so the process is killed in normal scenario (it won't be killed correclty if `kill -9` is used, but we can't do anything about that). Fixes hazelcast/hazelcast-enterprise#4425
Intermediate Java process was used to provide additional classpath or JVM parameters from command line parameters. However, there are issues with the approach: - there are 2 JVMs running, consuming resources - it's not clear to the user what the processes are for, what should be killed - killing with `kill -9` the parent process actually doesn't kill the child process
frant-hartm
added
Type: Enhancement
Source: Internal
|
@vbekiaris I just want to double-check that it is ok to backport this, as it's kind of a new feature and not trivial (but neither really complex). |
vbekiaris
approved these changes
Mar 1, 2022
ufukyilmaz
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to backport the
hz startscript to provide a unified experience across recent versions.This is a backport of the following PRs:
#20262
#20346
#20489
#19749 (small improvement in error message, makes the following PR easier to backport)
#20687
The backport is clean apart from the #20687 which removes code changed on the main branch but not in 5.0.z.
Checklist:
Team:,Type:,Source:,Module:) and Milestone setAdd to Release NotesorNot Release Notes contentset