Log map name when snapshot validation fails #20822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frant-hartm
added
Type: Enhancement
Source: Internal
frant-hartm
force-pushed
the
fix/damaged-snapshot-log-map-name
branch
from
f72d1fa
to
1538040
Compare
ufukyilmaz
approved these changes
Feb 23, 2022
There was a problem hiding this comment.
LGTM. Comparing these new logs with the logs printed here: https://github.com/hazelcast/hazelcast/blob/master/hazelcast/src/main/java/com/hazelcast/jet/impl/MasterSnapshotContext.java#L313-L318 will give us more insight 👍
frant-hartm
added a commit
to frant-hartm/hazelcast
that referenced
this pull request
Mar 2, 2022
4 tasks
frant-hartm
added a commit
to frant-hartm/hazelcast
that referenced
this pull request
Mar 2, 2022
Forward port of hazelcast#20822
4 tasks
frant-hartm
added a commit
that referenced
this pull request
Mar 4, 2022
* Log map name when snapshot validation fails [5.1.z] Forward port of #20822
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Team:,Type:,Source:,Module:) and Milestone setAdd to Release NotesorNot Release Notes contentset