Improve local hostname resolution by trying different methods #22512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldziedziul
added
Source: Internal
ldziedziul
force-pushed
the
improve-local-hostname-resolution
branch
from
538483c
to
0a9b9ed
Compare
ldziedziul
force-pushed
the
improve-local-hostname-resolution
branch
from
0a9b9ed
to
2893ef4
Compare
ramizdundar
approved these changes
Oct 17, 2022
|
The job Click to expand the log file-------------------------- -------TEST FAILURE------- -------------------------- [INFO] Results: [INFO] [ERROR] Errors: [ERROR] AuthenticationInformationLeakTest.testAuthenticationExceptionDoesNotLeakInfo:99->getKeyValue:170 ? EOF [INFO] [ERROR] Tests run: 4346, Failures: 0, Errors: 1, Skipped: 8 [INFO] |
|
run-lab-run |
vbekiaris
added a commit
that referenced
this pull request
Oct 17, 2022
…22501) - Adds automated cluster state management for persistence on kubernetes - Supports cluster-wide shutdown, rolling restart and partial member recovery from failure on kubernetes [HZ-1190] [HZ-1191] [HZ-1193] - Fixes behaviour of readiness probe with persistence enabled [HZ-1349] - Allows tuning either for speedy crash recovery with FROZEN state or availability of in-memory data structures with NO_MIGRATION state for missing members [HZ-1311] - Fixes backup sync after single member crash recovery [HZ-1349] Design document in EE side: https://github.com/vbekiaris/hazelcast-enterprise/blob/enhancements/5.2/k8s-persistence/docs/design/persistence/04-persistence-kubernetes-improvements.md (cherry picked from commit 1ddc16e) 1:1 clean backport of #21844 to 5.2.0 release branch Also includes backport of #22512 Co-authored-by: Łukasz Dziedziul <lukasz.dziedziul@hazelcast.com>
|
The job Click to expand the log file-------------------------- -------TEST FAILURE------- -------------------------- [INFO] Results: [INFO] [ERROR] Failures: [ERROR] ClientQueryCacheRecreationTest.listeners_still_works_after_query_cache_recreation:154->HazelcastTestSupport.assertTrueEventually:1338->HazelcastTestSupport.assertTrueEventually:1236->lambda$listeners_still_works_after_query_cache_recreation$0:152 expected:<90> but was:<12> [INFO] [ERROR] Tests run: 50915, Failures: 1, Errors: 0, Skipped: 238 [INFO] |
|
run-lab-run |
|
The job Click to expand the log file-------------------------- -------TEST FAILURE------- -------------------------- [INFO] Results: [INFO] [ERROR] Errors: [ERROR] AuthenticationInformationLeakTest.testAuthenticationExceptionDoesNotLeakInfo:99->getKeyValue:170 ? EOF [INFO] [ERROR] Tests run: 4346, Failures: 0, Errors: 1, Skipped: 8 [INFO] |
| Process exec = Runtime.getRuntime().exec("hostname"); | ||
| exec.waitFor(PROCESS_TIMEOUT_IN_SECONDS, TimeUnit.SECONDS); | ||
| InputStream stream = exec.getInputStream(); | ||
| return new BufferedReader(new InputStreamReader(stream)).lines().collect(Collectors.joining("\n")); |
There was a problem hiding this comment.
shouldn't this be in try-with-resources to avoid leaks?
There was a problem hiding this comment.
I think it's not necessary since process streams are closed when the process is finished.
vbekiaris
added a commit
that referenced
this pull request
Oct 19, 2022
…22502) - Adds automated cluster state management for persistence on kubernetes - Supports cluster-wide shutdown, rolling restart and partial member recovery from failure on kubernetes [HZ-1190] [HZ-1191] [HZ-1193] - Fixes behaviour of readiness probe with persistence enabled [HZ-1349] - Allows tuning either for speedy crash recovery with FROZEN state or availability of in-memory data structures with NO_MIGRATION state for missing members [HZ-1311] - Fixes backup sync after single member crash recovery [HZ-1349] Design document in EE side: https://github.com/vbekiaris/hazelcast-enterprise/blob/enhancements/5.2/k8s-persistence/docs/design/persistence/04-persistence-kubernetes-improvements.md (cherry picked from commit 1ddc16e) 1:1 clean backport from #21844 Also includes backport of #22512 Co-authored-by: Łukasz Dziedziul <lukasz.dziedziul@hazelcast.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting hostname from HOSTNAME env variables doesn't work on vanilla non-containerised Ubuntu systems.
Here's the failures on non-dockerized env: https://jenkins.hazelcast.com/job/Hazelcast-master-OracleJDK8-Esxi7/4/#showFailuresLink
Example on clean AWS ubuntu:
ubuntu version
java version
Getting hostname with different methods
This PR tries to improve hostname resolution by trying different methods:
hostnamesystem commandInetAddress.getLocalHost().getHostName()(broken DNS setup can break it)Reference: