Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct Javadoc on CacheConfiguration.setManagementEnabled(boolean) #22575

Merged
merged 1 commit into from Aug 16, 2023
Merged

Correct Javadoc on CacheConfiguration.setManagementEnabled(boolean) #22575

merged 1 commit into from Aug 16, 2023

Conversation

jxblum
Copy link
Contributor

@jxblum jxblum commented Oct 21, 2022 •
edited

Please see #22574.

@jxblum
Correct Javadoc on CacheConfiguration.setManagementEnabled(boolean)
45f9e02 
@param enabled refers to "statistics"; should be "management"

Resolves hazelcast#22574
@hz-devops-test hz-devops-test added the Source: Community PR or issue was opened by a community user label Oct 21, 2022
@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

11 similar comments
@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@TomaszGaweda
Copy link
Contributor

Hi! Thanks for the correction, I've triggered builds for this PR. Please fill the PR description according to our template @jxblum

@TomaszGaweda
Copy link
Contributor

run-lab-run

@TomaszGaweda TomaszGaweda added this to the 5.3.0 milestone Oct 25, 2022
@jxblum jxblum marked this pull request as draft October 26, 2022 17:50
@jxblum jxblum marked this pull request as ready for review October 26, 2022 17:52
@jxblum
Copy link
Contributor Author

jxblum commented Oct 26, 2022 •
edited

Can you please provide a reference to your PR template?

Also, does this simple documentation (Javadoc) change really require an extensive checklist? 1) I filed an Issue ticket for this PR and 2) I also filed a similar Issue/PR for another Javadoc issue, which has already been closed/merged.

I am happy to comply if necessary, but would appreciate a link to the template. Thanks.

@AyberkSorgun AyberkSorgun modified the milestones: 5.3.0, 5.4.0 May 16, 2023
@pveentjer
Copy link
Contributor

pveentjer commented Aug 16, 2023 •
edited

PR description is fine; we are talking about a 1 word documentation change here.

@pveentjer pveentjer merged commit 055412b into hazelcast:master Aug 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pveentjer pveentjer pveentjer approved these changes

Assignees
No one assigned
Labels
Source: Community PR or issue was opened by a community user
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jxblum @devOpsHazelcast @TomaszGaweda @pveentjer @AyberkSorgun @hz-devops-test