Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Hazelcast version in the protocol definitions #23039

Closed
wants to merge 5 commits into from

Conversation

mdumandag
Copy link
Contributor

We were using the separate protocol version in the since values
of the protocol definitions, but that was causing a quite bit
of confusion.

We have decided to stick to the Hazelcast versions to make it simpler.

This PR updates the auto-generated test files with the changes
done on the protocol side and updates the since versions used in
the LongRegister.

protocol PR: hazelcast/hazelcast-client-protocol#444

@mdumandag mdumandag added this to the 5.3.0 milestone Dec 1, 2022
@mdumandag mdumandag requested a review from a team as a code owner December 1, 2022 13:40
@mdumandag mdumandag self-assigned this Dec 1, 2022
We were using the separate protocol version in the since values
of the protocol definitions, but that was causing a quite bit
of confusion.

We have decided to stick to the Hazelcast versions to make it simpler.

This PR updates the auto-generated test files with the changes
done on the protocol side and updates the since versions used in
the `LongRegister`.
@hz-devops-test
Copy link

The job Hazelcast-pr-builder of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file

@mdumandag
Copy link
Contributor Author

run-lab-run

@mdumandag mdumandag modified the milestones: 5.3.0, 5.4 Backlog Mar 2, 2023
@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

2 similar comments
@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@hz-devops-test
Copy link

The job Hazelcast-pr-compiler of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file
--------------------------
---------SUMMARY----------
--------------------------
[ERROR] COMPILATION ERROR : 
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-compiler/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityNullTest_2_7.java:[51,8] class ClientCompatibilityNullTest_5_4 is public, should be declared in a file named ClientCompatibilityNullTest_5_4.java
--------------------------
---------ERRORS-----------
--------------------------
[ERROR] COMPILATION ERROR : 
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-compiler/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityNullTest_2_7.java:[51,8] class ClientCompatibilityNullTest_5_4 is public, should be declared in a file named ClientCompatibilityNullTest_5_4.java
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-compiler/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5913,63] method encodeRequest in class com.hazelcast.client.impl.protocol.codec.DynamicConfigAddMapConfigCodec cannot be applied to given types;
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-compiler/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5978,33] cannot find symbol
--------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:testCompile (default-testCompile) on project hazelcast: Compilation failure: Compilation failure: 
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-compiler/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityNullTest_2_7.java:[51,8] class ClientCompatibilityNullTest_5_4 is public, should be declared in a file named ClientCompatibilityNullTest_5_4.java
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-compiler/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5913,63] method encodeRequest in class com.hazelcast.client.impl.protocol.codec.DynamicConfigAddMapConfigCodec cannot be applied to given types;
--------------------------
[ERROR]   required: java.lang.String,int,int,int,int,com.hazelcast.client.impl.protocol.task.dynamicconfig.EvictionConfigHolder,boolean,java.lang.String,java.lang.String,int,java.lang.String,java.util.Collection,java.util.Collection,boolean,java.lang.String,com.hazelcast.client.impl.protocol.task.dynamicconfig.MapStoreConfigHolder,com.hazelcast.client.impl.protocol.task.dynamicconfig.NearCacheConfigHolder,com.hazelcast.config.WanReplicationRef,java.util.Collection,java.util.Collection,java.util.Collection,java.lang.String,com.hazelcast.internal.serialization.Data,com.hazelcast.config.HotRestartConfig,com.hazelcast.config.EventJournalConfig,com.hazelcast.config.MerkleTreeConfig,int,boolean,com.hazelcast.config.DataPersistenceConfig,com.hazelcast.config.TieredStoreConfig,java.util.Collection
--------------------------
[ERROR]   found: java.lang.String,int,int,int,int,com.hazelcast.client.impl.protocol.task.dynamicconfig.EvictionConfigHolder,boolean,java.lang.String,java.lang.String,int,java.lang.String,java.util.List,java.util.List,boolean,java.lang.String,com.hazelcast.client.impl.protocol.task.dynamicconfig.MapStoreConfigHolder,com.hazelcast.client.impl.protocol.task.dynamicconfig.NearCacheConfigHolder,com.hazelcast.config.WanReplicationRef,java.util.List,java.util.List,java.util.List,java.lang.String,com.hazelcast.internal.serialization.Data,com.hazelcast.config.HotRestartConfig,com.hazelcast.config.EventJournalConfig,com.hazelcast.config.MerkleTreeConfig,int,boolean,com.hazelcast.config.DataPersistenceConfig,com.hazelcast.config.TieredStoreConfig
--------------------------
[ERROR]   reason: actual and formal argument lists differ in length
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-compiler/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5978,33] cannot find symbol
--------------------------
[ERROR]   symbol:   variable DynamicConfigAddExternalDataStoreConfigCodec
--------------------------
[ERROR]   location: class com.hazelcast.client.protocol.compatibility.ClientCompatibilityTest_5_3
--------------------------
[ERROR] -> [Help 1]
--------------------------
[ERROR] 
--------------------------
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
--------------------------
[ERROR] 
--------------------------
[ERROR] For more information about the errors and possible solutions, please read the following articles:
--------------------------
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
--------------------------
[ERROR] 
--------------------------
[ERROR] After correcting the problems, you can resume the build with the command
--------------------------
[ERROR]   mvn  -rf :hazelcast
--------------------------

@hz-devops-test
Copy link

The job Hazelcast-pr-builder of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file
--------------------------
---------SUMMARY----------
--------------------------
[ERROR] COMPILATION ERROR : 
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityNullTest_2_7.java:[51,8] class ClientCompatibilityNullTest_5_4 is public, should be declared in a file named ClientCompatibilityNullTest_5_4.java
--------------------------
---------ERRORS-----------
--------------------------
[ERROR] COMPILATION ERROR : 
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityNullTest_2_7.java:[51,8] class ClientCompatibilityNullTest_5_4 is public, should be declared in a file named ClientCompatibilityNullTest_5_4.java
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5913,63] method encodeRequest in class com.hazelcast.client.impl.protocol.codec.DynamicConfigAddMapConfigCodec cannot be applied to given types;
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5978,33] cannot find symbol
--------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:testCompile (default-testCompile) on project hazelcast: Compilation failure: Compilation failure: 
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityNullTest_2_7.java:[51,8] class ClientCompatibilityNullTest_5_4 is public, should be declared in a file named ClientCompatibilityNullTest_5_4.java
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5913,63] method encodeRequest in class com.hazelcast.client.impl.protocol.codec.DynamicConfigAddMapConfigCodec cannot be applied to given types;
--------------------------
[ERROR]   required: java.lang.String,int,int,int,int,com.hazelcast.client.impl.protocol.task.dynamicconfig.EvictionConfigHolder,boolean,java.lang.String,java.lang.String,int,java.lang.String,java.util.Collection,java.util.Collection,boolean,java.lang.String,com.hazelcast.client.impl.protocol.task.dynamicconfig.MapStoreConfigHolder,com.hazelcast.client.impl.protocol.task.dynamicconfig.NearCacheConfigHolder,com.hazelcast.config.WanReplicationRef,java.util.Collection,java.util.Collection,java.util.Collection,java.lang.String,com.hazelcast.internal.serialization.Data,com.hazelcast.config.HotRestartConfig,com.hazelcast.config.EventJournalConfig,com.hazelcast.config.MerkleTreeConfig,int,boolean,com.hazelcast.config.DataPersistenceConfig,com.hazelcast.config.TieredStoreConfig,java.util.Collection
--------------------------
[ERROR]   found: java.lang.String,int,int,int,int,com.hazelcast.client.impl.protocol.task.dynamicconfig.EvictionConfigHolder,boolean,java.lang.String,java.lang.String,int,java.lang.String,java.util.List,java.util.List,boolean,java.lang.String,com.hazelcast.client.impl.protocol.task.dynamicconfig.MapStoreConfigHolder,com.hazelcast.client.impl.protocol.task.dynamicconfig.NearCacheConfigHolder,com.hazelcast.config.WanReplicationRef,java.util.List,java.util.List,java.util.List,java.lang.String,com.hazelcast.internal.serialization.Data,com.hazelcast.config.HotRestartConfig,com.hazelcast.config.EventJournalConfig,com.hazelcast.config.MerkleTreeConfig,int,boolean,com.hazelcast.config.DataPersistenceConfig,com.hazelcast.config.TieredStoreConfig
--------------------------
[ERROR]   reason: actual and formal argument lists differ in length
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5978,33] cannot find symbol
--------------------------
[ERROR]   symbol:   variable DynamicConfigAddExternalDataStoreConfigCodec
--------------------------
[ERROR]   location: class com.hazelcast.client.protocol.compatibility.ClientCompatibilityTest_5_3
--------------------------
[ERROR] -> [Help 1]
--------------------------
[ERROR] 
--------------------------
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
--------------------------
[ERROR] 
--------------------------
[ERROR] For more information about the errors and possible solutions, please read the following articles:
--------------------------
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
--------------------------
[ERROR] 
--------------------------
[ERROR] After correcting the problems, you can resume the build with the command
--------------------------
[ERROR]   mvn  -rf :hazelcast
--------------------------

@hz-devops-test
Copy link

The job Hazelcast-pr-EE-compiler of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file
--------------------------
---------SUMMARY----------
--------------------------
[ERROR] COMPILATION ERROR : 
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityNullTest_2_7.java:[51,8] class ClientCompatibilityNullTest_5_4 is public, should be declared in a file named ClientCompatibilityNullTest_5_4.java
--------------------------
---------ERRORS-----------
--------------------------
[ERROR] COMPILATION ERROR : 
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityNullTest_2_7.java:[51,8] class ClientCompatibilityNullTest_5_4 is public, should be declared in a file named ClientCompatibilityNullTest_5_4.java
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5913,63] method encodeRequest in class com.hazelcast.client.impl.protocol.codec.DynamicConfigAddMapConfigCodec cannot be applied to given types;
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5978,33] cannot find symbol
--------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:testCompile (default-testCompile) on project hazelcast: Compilation failure: Compilation failure: 
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityNullTest_2_7.java:[51,8] class ClientCompatibilityNullTest_5_4 is public, should be declared in a file named ClientCompatibilityNullTest_5_4.java
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5913,63] method encodeRequest in class com.hazelcast.client.impl.protocol.codec.DynamicConfigAddMapConfigCodec cannot be applied to given types;
--------------------------
[ERROR]   required: java.lang.String,int,int,int,int,com.hazelcast.client.impl.protocol.task.dynamicconfig.EvictionConfigHolder,boolean,java.lang.String,java.lang.String,int,java.lang.String,java.util.Collection,java.util.Collection,boolean,java.lang.String,com.hazelcast.client.impl.protocol.task.dynamicconfig.MapStoreConfigHolder,com.hazelcast.client.impl.protocol.task.dynamicconfig.NearCacheConfigHolder,com.hazelcast.config.WanReplicationRef,java.util.Collection,java.util.Collection,java.util.Collection,java.lang.String,com.hazelcast.internal.serialization.Data,com.hazelcast.config.HotRestartConfig,com.hazelcast.config.EventJournalConfig,com.hazelcast.config.MerkleTreeConfig,int,boolean,com.hazelcast.config.DataPersistenceConfig,com.hazelcast.config.TieredStoreConfig,java.util.Collection
--------------------------
[ERROR]   found: java.lang.String,int,int,int,int,com.hazelcast.client.impl.protocol.task.dynamicconfig.EvictionConfigHolder,boolean,java.lang.String,java.lang.String,int,java.lang.String,java.util.List,java.util.List,boolean,java.lang.String,com.hazelcast.client.impl.protocol.task.dynamicconfig.MapStoreConfigHolder,com.hazelcast.client.impl.protocol.task.dynamicconfig.NearCacheConfigHolder,com.hazelcast.config.WanReplicationRef,java.util.List,java.util.List,java.util.List,java.lang.String,com.hazelcast.internal.serialization.Data,com.hazelcast.config.HotRestartConfig,com.hazelcast.config.EventJournalConfig,com.hazelcast.config.MerkleTreeConfig,int,boolean,com.hazelcast.config.DataPersistenceConfig,com.hazelcast.config.TieredStoreConfig
--------------------------
[ERROR]   reason: actual and formal argument lists differ in length
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5978,33] cannot find symbol
--------------------------
[ERROR]   symbol:   variable DynamicConfigAddExternalDataStoreConfigCodec
--------------------------
[ERROR]   location: class com.hazelcast.client.protocol.compatibility.ClientCompatibilityTest_5_3
--------------------------
[ERROR] -> [Help 1]
--------------------------
[ERROR] 
--------------------------
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
--------------------------
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
--------------------------
[ERROR] 
--------------------------
[ERROR] For more information about the errors and possible solutions, please read the following articles:
--------------------------
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
--------------------------
[ERROR] 
--------------------------
[ERROR] After correcting the problems, you can resume the build with the command
--------------------------
[ERROR]   mvn  -rf :hazelcast
--------------------------

@hz-devops-test
Copy link

The job Hazelcast-pr-builder of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file
--------------------------
---------SUMMARY----------
--------------------------
[ERROR] COMPILATION ERROR : 
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5913,63] method encodeRequest in class com.hazelcast.client.impl.protocol.codec.DynamicConfigAddMapConfigCodec cannot be applied to given types;
--------------------------
---------ERRORS-----------
--------------------------
[ERROR] COMPILATION ERROR : 
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5913,63] method encodeRequest in class com.hazelcast.client.impl.protocol.codec.DynamicConfigAddMapConfigCodec cannot be applied to given types;
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5978,33] cannot find symbol
--------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:testCompile (default-testCompile) on project hazelcast: Compilation failure: Compilation failure: 
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5913,63] method encodeRequest in class com.hazelcast.client.impl.protocol.codec.DynamicConfigAddMapConfigCodec cannot be applied to given types;
--------------------------
[ERROR]   required: java.lang.String,int,int,int,int,com.hazelcast.client.impl.protocol.task.dynamicconfig.EvictionConfigHolder,boolean,java.lang.String,java.lang.String,int,java.lang.String,java.util.Collection,java.util.Collection,boolean,java.lang.String,com.hazelcast.client.impl.protocol.task.dynamicconfig.MapStoreConfigHolder,com.hazelcast.client.impl.protocol.task.dynamicconfig.NearCacheConfigHolder,com.hazelcast.config.WanReplicationRef,java.util.Collection,java.util.Collection,java.util.Collection,java.lang.String,com.hazelcast.internal.serialization.Data,com.hazelcast.config.HotRestartConfig,com.hazelcast.config.EventJournalConfig,com.hazelcast.config.MerkleTreeConfig,int,boolean,com.hazelcast.config.DataPersistenceConfig,com.hazelcast.config.TieredStoreConfig,java.util.Collection
--------------------------
[ERROR]   found: java.lang.String,int,int,int,int,com.hazelcast.client.impl.protocol.task.dynamicconfig.EvictionConfigHolder,boolean,java.lang.String,java.lang.String,int,java.lang.String,java.util.List,java.util.List,boolean,java.lang.String,com.hazelcast.client.impl.protocol.task.dynamicconfig.MapStoreConfigHolder,com.hazelcast.client.impl.protocol.task.dynamicconfig.NearCacheConfigHolder,com.hazelcast.config.WanReplicationRef,java.util.List,java.util.List,java.util.List,java.lang.String,com.hazelcast.internal.serialization.Data,com.hazelcast.config.HotRestartConfig,com.hazelcast.config.EventJournalConfig,com.hazelcast.config.MerkleTreeConfig,int,boolean,com.hazelcast.config.DataPersistenceConfig,com.hazelcast.config.TieredStoreConfig
--------------------------
[ERROR]   reason: actual and formal argument lists differ in length
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5978,33] cannot find symbol
--------------------------
[ERROR]   symbol:   variable DynamicConfigAddExternalDataStoreConfigCodec
--------------------------
[ERROR]   location: class com.hazelcast.client.protocol.compatibility.ClientCompatibilityTest_5_3
--------------------------
[ERROR] -> [Help 1]
--------------------------
[ERROR] 
--------------------------
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
--------------------------
[ERROR] 
--------------------------
[ERROR] For more information about the errors and possible solutions, please read the following articles:
--------------------------
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
--------------------------
[ERROR] 
--------------------------
[ERROR] After correcting the problems, you can resume the build with the command
--------------------------
[ERROR]   mvn  -rf :hazelcast
--------------------------

@hz-devops-test
Copy link

The job Hazelcast-pr-compiler of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file
--------------------------
---------SUMMARY----------
--------------------------
[ERROR] COMPILATION ERROR : 
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-compiler/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5913,63] method encodeRequest in class com.hazelcast.client.impl.protocol.codec.DynamicConfigAddMapConfigCodec cannot be applied to given types;
--------------------------
---------ERRORS-----------
--------------------------
[ERROR] COMPILATION ERROR : 
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-compiler/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5913,63] method encodeRequest in class com.hazelcast.client.impl.protocol.codec.DynamicConfigAddMapConfigCodec cannot be applied to given types;
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-compiler/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5978,33] cannot find symbol
--------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:testCompile (default-testCompile) on project hazelcast: Compilation failure: Compilation failure: 
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-compiler/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5913,63] method encodeRequest in class com.hazelcast.client.impl.protocol.codec.DynamicConfigAddMapConfigCodec cannot be applied to given types;
--------------------------
[ERROR]   required: java.lang.String,int,int,int,int,com.hazelcast.client.impl.protocol.task.dynamicconfig.EvictionConfigHolder,boolean,java.lang.String,java.lang.String,int,java.lang.String,java.util.Collection,java.util.Collection,boolean,java.lang.String,com.hazelcast.client.impl.protocol.task.dynamicconfig.MapStoreConfigHolder,com.hazelcast.client.impl.protocol.task.dynamicconfig.NearCacheConfigHolder,com.hazelcast.config.WanReplicationRef,java.util.Collection,java.util.Collection,java.util.Collection,java.lang.String,com.hazelcast.internal.serialization.Data,com.hazelcast.config.HotRestartConfig,com.hazelcast.config.EventJournalConfig,com.hazelcast.config.MerkleTreeConfig,int,boolean,com.hazelcast.config.DataPersistenceConfig,com.hazelcast.config.TieredStoreConfig,java.util.Collection
--------------------------
[ERROR]   found: java.lang.String,int,int,int,int,com.hazelcast.client.impl.protocol.task.dynamicconfig.EvictionConfigHolder,boolean,java.lang.String,java.lang.String,int,java.lang.String,java.util.List,java.util.List,boolean,java.lang.String,com.hazelcast.client.impl.protocol.task.dynamicconfig.MapStoreConfigHolder,com.hazelcast.client.impl.protocol.task.dynamicconfig.NearCacheConfigHolder,com.hazelcast.config.WanReplicationRef,java.util.List,java.util.List,java.util.List,java.lang.String,com.hazelcast.internal.serialization.Data,com.hazelcast.config.HotRestartConfig,com.hazelcast.config.EventJournalConfig,com.hazelcast.config.MerkleTreeConfig,int,boolean,com.hazelcast.config.DataPersistenceConfig,com.hazelcast.config.TieredStoreConfig
--------------------------
[ERROR]   reason: actual and formal argument lists differ in length
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-compiler/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5978,33] cannot find symbol
--------------------------
[ERROR]   symbol:   variable DynamicConfigAddExternalDataStoreConfigCodec
--------------------------
[ERROR]   location: class com.hazelcast.client.protocol.compatibility.ClientCompatibilityTest_5_3
--------------------------
[ERROR] -> [Help 1]
--------------------------
[ERROR] 
--------------------------
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
--------------------------
[ERROR] 
--------------------------
[ERROR] For more information about the errors and possible solutions, please read the following articles:
--------------------------
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
--------------------------
[ERROR] 
--------------------------
[ERROR] After correcting the problems, you can resume the build with the command
--------------------------
[ERROR]   mvn  -rf :hazelcast
--------------------------

@hz-devops-test
Copy link

The job Hazelcast-pr-EE-compiler of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file
--------------------------
---------SUMMARY----------
--------------------------
[ERROR] COMPILATION ERROR : 
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5913,63] method encodeRequest in class com.hazelcast.client.impl.protocol.codec.DynamicConfigAddMapConfigCodec cannot be applied to given types;
--------------------------
---------ERRORS-----------
--------------------------
[ERROR] COMPILATION ERROR : 
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5913,63] method encodeRequest in class com.hazelcast.client.impl.protocol.codec.DynamicConfigAddMapConfigCodec cannot be applied to given types;
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5978,33] cannot find symbol
--------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:testCompile (default-testCompile) on project hazelcast: Compilation failure: Compilation failure: 
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5913,63] method encodeRequest in class com.hazelcast.client.impl.protocol.codec.DynamicConfigAddMapConfigCodec cannot be applied to given types;
--------------------------
[ERROR]   required: java.lang.String,int,int,int,int,com.hazelcast.client.impl.protocol.task.dynamicconfig.EvictionConfigHolder,boolean,java.lang.String,java.lang.String,int,java.lang.String,java.util.Collection,java.util.Collection,boolean,java.lang.String,com.hazelcast.client.impl.protocol.task.dynamicconfig.MapStoreConfigHolder,com.hazelcast.client.impl.protocol.task.dynamicconfig.NearCacheConfigHolder,com.hazelcast.config.WanReplicationRef,java.util.Collection,java.util.Collection,java.util.Collection,java.lang.String,com.hazelcast.internal.serialization.Data,com.hazelcast.config.HotRestartConfig,com.hazelcast.config.EventJournalConfig,com.hazelcast.config.MerkleTreeConfig,int,boolean,com.hazelcast.config.DataPersistenceConfig,com.hazelcast.config.TieredStoreConfig,java.util.Collection
--------------------------
[ERROR]   found: java.lang.String,int,int,int,int,com.hazelcast.client.impl.protocol.task.dynamicconfig.EvictionConfigHolder,boolean,java.lang.String,java.lang.String,int,java.lang.String,java.util.List,java.util.List,boolean,java.lang.String,com.hazelcast.client.impl.protocol.task.dynamicconfig.MapStoreConfigHolder,com.hazelcast.client.impl.protocol.task.dynamicconfig.NearCacheConfigHolder,com.hazelcast.config.WanReplicationRef,java.util.List,java.util.List,java.util.List,java.lang.String,com.hazelcast.internal.serialization.Data,com.hazelcast.config.HotRestartConfig,com.hazelcast.config.EventJournalConfig,com.hazelcast.config.MerkleTreeConfig,int,boolean,com.hazelcast.config.DataPersistenceConfig,com.hazelcast.config.TieredStoreConfig
--------------------------
[ERROR]   reason: actual and formal argument lists differ in length
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast/hazelcast/src/test/java/com/hazelcast/client/protocol/compatibility/ClientCompatibilityTest_5_3.java:[5978,33] cannot find symbol
--------------------------
[ERROR]   symbol:   variable DynamicConfigAddExternalDataStoreConfigCodec
--------------------------
[ERROR]   location: class com.hazelcast.client.protocol.compatibility.ClientCompatibilityTest_5_3
--------------------------
[ERROR] -> [Help 1]
--------------------------
[ERROR] 
--------------------------
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
--------------------------
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
--------------------------
[ERROR] 
--------------------------
[ERROR] For more information about the errors and possible solutions, please read the following articles:
--------------------------
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
--------------------------
[ERROR] 
--------------------------
[ERROR] After correcting the problems, you can resume the build with the command
--------------------------
[ERROR]   mvn  -rf :hazelcast
--------------------------

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting, should not we have 5.3 test already?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have ClientCompatibilityTest_2_6 already in master

Copy link
Member

@srknzl srknzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good except a comment

@devOpsHazelcast
Copy link
Collaborator

PR closed by Hazelcast automation as no activity (>3 months). Please reopen with comments, if necessary. Thank you for using Hazelcast and your valuable contributions

@AyberkSorgun AyberkSorgun removed this from the 5.4 Backlog milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants