Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly specify executor for CF calls in the 'cp' package [HZ-2005] #23529

Merged
merged 1 commit into from Feb 20, 2023

Conversation

arodionov
Copy link
Contributor

@arodionov arodionov commented Jan 31, 2023

Moving away from using the ForkJoinPool#commonPool for the cp package.

Related to #18190

Checklist:

  • Labels (Team:, Type:, Source:, Module:) and Milestone set
  • Label Add to Release Notes or Not Release Notes content set
  • Request reviewers if possible
  • Send backports/forwardports if fix needs to be applied to past/future releases
  • New public APIs have @Nonnull/@Nullable annotations
  • New public APIs have @since tags in Javadoc

Moving away from using the `ForkJoinPool#commonPool` for the `cp` package.
Related to hazelcast#18190
@arodionov arodionov added this to the 5.3.0 milestone Jan 31, 2023
@hz-devops-test
Copy link

The job Hazelcast-pr-EE-compiler of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file
--------------------------
---------SUMMARY----------
--------------------------
[ERROR] Failed to execute goal org.codehaus.mojo:license-maven-plugin:2.0.0:add-third-party (add-third-party) on project hazelcast-distribution: There are some forbidden licenses used, please check your dependencies. -> [Help 1]
--------------------------

@vbekiaris
Copy link
Collaborator

run-ee-compile

@vbekiaris
Copy link
Collaborator

run-sonar

}
});
}, internalAsyncExecutor);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internalAsyncExecutor usage is not triggered by user code, i assume.

Copy link
Contributor Author

@arodionov arodionov Feb 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I see, the AtomicLongProxy#localGetAsync and AtomicLongProxy#localGet currently are not used.

Copy link
Member

@ahmetmircik ahmetmircik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arodionov arodionov merged commit e929244 into hazelcast:master Feb 20, 2023
@vbekiaris vbekiaris added Source: Internal PR or issue was opened by an employee and removed Source: Community PR or issue was opened by a community user labels May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants