Generate suggested DDL for HD IMaps without indexes and TS IMaps [HZ-2190] [HZ-2191]

[k-jamroz]

Removed leftover checks from time when iteration on HD maps required index. Added beforeOperation() required by Tiered Storage.

Fixes HZ-2190, HZ-2191
EE PR: https://github.com/hazelcast/hazelcast-enterprise/pull/5842

Checklist:

• Labels (Team:, Type:, Source:, Module:) and Milestone set
• Label Add to Release Notes or Not Release Notes content set
• Request reviewers if possible
• Send backports/forwardports if fix needs to be applied to past/future releases

[hz-devops-test]

The job Hazelcast-pr-builder of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file

--------------------------
---------SUMMARY----------
--------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.2.1:checkstyle (default) on project hazelcast-sql: An error has occurred in Checkstyle report generation. Failed during checkstyle execution: There is 1 error reported by Checkstyle 8.38 with /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/checkstyle/checkstyle.xml ruleset. -> [Help 1]
--------------------------
---------ERRORS-----------
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast-sql/src/main/java/com/hazelcast/jet/sql/impl/connector/map/MetadataResolver.java:99:5: Class GetAnyMetadataOperation should be declared as final. [FinalClass]
--------------------------

[hz-devops-test]

The job Hazelcast-pr-compiler of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file

--------------------------
---------SUMMARY----------
--------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.2.1:checkstyle (default) on project hazelcast-sql: An error has occurred in Checkstyle report generation. Failed during checkstyle execution: There is 1 error reported by Checkstyle 8.38 with /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-compiler/checkstyle/checkstyle.xml ruleset. -> [Help 1]
--------------------------
---------ERRORS-----------
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-compiler/hazelcast-sql/src/main/java/com/hazelcast/jet/sql/impl/connector/map/MetadataResolver.java:99:5: Class GetAnyMetadataOperation should be declared as final. [FinalClass]
--------------------------

[hz-devops-test]

The job Hazelcast-pr-builder of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file

--------------------------
-------TEST FAILURE-------
--------------------------
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   MongoStreamSqlConnectorTest.readsFromMongo_withId_oneStep:52->readsFromMongo:110->SqlTestSupport.assertRowsEventuallyInAnyOrder:289 
Expecting actual:
  [Row{[Anakin, Skywalker, insert]}]
to contain exactly in any order:
  [Row{[Luke, Skywalker, insert]}, Row{[Anakin, Skywalker, insert]}]
but could not find the following elements:
  [Row{[Luke, Skywalker, insert]}]
[INFO]

[ERROR] Tests run: 5340, Failures: 1, Errors: 0, Skipped: 19

[INFO]
[ERROR] There are test failures.

[hz-devops-test]

The job Hazelcast-pr-builder of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file

[k-jamroz]

run-lab-run

[hz-devops-test]

The job Hazelcast-pr-builder of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file

--------------------------
-------TEST FAILURE-------
--------------------------
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   MongoStreamSqlConnectorTest.readsFromMongo_withoutId_twoSteps:57->readsFromMongo:111->SqlTestSupport.assertRowsEventuallyInAnyOrder:293 
Expecting actual:
  [Row{[Anakin, Skywalker, insert]}]
to contain exactly in any order:
  [Row{[Luke, Skywalker, insert]}, Row{[Anakin, Skywalker, insert]}]
but could not find the following elements:
  [Row{[Luke, Skywalker, insert]}]
[INFO]

[ERROR] Tests run: 5481, Failures: 1, Errors: 0, Skipped: 19

[INFO]
[ERROR] There are test failures.

[ahmetmircik]

1 comment for a nice to have thing + LGTM