Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapStore support for tiered store [HZ-1680] #24827

Merged
merged 9 commits into from Jul 20, 2023

Conversation

ahmetmircik
Copy link
Member

@ahmetmircik ahmetmircik commented Jun 15, 2023

@ahmetmircik ahmetmircik force-pushed the map-loader branch 2 times, most recently from eee19a7 to cef4a61 Compare June 15, 2023 12:32
@ahmetmircik ahmetmircik changed the title wip MapStore support for tiered store Jun 23, 2023
@ahmetmircik ahmetmircik added this to the 5.4.0 milestone Jun 23, 2023
@ahmetmircik ahmetmircik changed the title MapStore support for tiered store MapStore support for tiered store [HZ-1680] Jun 23, 2023
@ahmetmircik ahmetmircik force-pushed the map-loader branch 2 times, most recently from f1b1779 to 36c9837 Compare July 13, 2023 11:58
@hazelcast hazelcast deleted a comment from hz-devops-test Jul 13, 2023
@ahmetmircik ahmetmircik marked this pull request as ready for review July 14, 2023 08:04
@ahmetmircik ahmetmircik requested a review from a team as a code owner July 14, 2023 08:04
Copy link
Contributor

@ihsandemir ihsandemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for the client related codes.

@@ -296,7 +297,7 @@ public void testSelectWithOrderByDescDescAsc() {
public void testSelectWithOrderByAndProject() {
// SELECT intVal, intVal + bigIntVal FROM t ORDER BY intVal, bigIntVal
String sql = sqlWithOrderBy(Arrays.asList("intVal",
"intVal + bigIntVal"),
"intVal + bigIntVal"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd avoid unnecessary reformatting

@ahmetmircik ahmetmircik merged commit 4601ab5 into hazelcast:master Jul 20, 2023
7 of 8 checks passed
@ahmetmircik ahmetmircik deleted the map-loader branch July 20, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants