[BACKPORT] Do not try to connect to the old member list after the cluster changes [API-2086] #24944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s [API-2038] (hazelcast#24745) During failover, when the client is about to try to connect to the next cluster, it resets some services including the cluster service. In its reset logic, cluster service clears the member list version, but leaves the members as it is, as there are some services/proxies that rely on the fact that the member list cannot be empty. This creates a problem for the failover case. After the cluster change, the client still tries to connect to the last known member list, which is the members of the previous cluster. To solve the problem, I have introduced a new method to the cluster service, which returns the "effective" member list. That is, it returns an empty list after the service is reset, but returns the member list as expected otherwise. With that, the connection logic simply skips the old member list after the client decides to change the cluster to try to connect to.
|
The job Click to expand the log file-------------------------- -------TEST FAILURE------- -------------------------- [INFO] Results: [INFO] [ERROR] Failures: [ERROR] SessionAwareSemaphoreReleaseAcquiredSessionsOnFailureTest.testDrainPermits_shouldReleaseSessionsOnRuntimeError:123 DrainPermits request should have been completed with InterruptedException [INFO] [ERROR] Tests run: 50949, Failures: 1, Errors: 0, Skipped: 238 [INFO] |
|
run-lab-run |
1 similar comment
|
run-lab-run |
ihsandemir
changed the title
srknzl
approved these changes
Jul 6, 2023
emreyigit
approved these changes
Jul 6, 2023
devOpsHazelcast
pushed a commit
that referenced
this pull request
Feb 26, 2024
…uster changes [API-2086] (#24944) (#790) [BACKPORT] Do not try to connect to the old member list after the cluster changes [API-2086] (#24944) Backports #24745 [API-2086]: https://hazelcast.atlassian.net/browse/API-2086?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: Metin Dumandag <29387993+mdumandag@users.noreply.github.com> GitOrigin-RevId: 457f91f42fe0fcc87f28fddd99c996b29391b6f5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #24745