Introduce a flow control to fix exponential backoff behaviour for CP subsystem [HZ-2702] #25055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arodionov
added
Type: Defect
Type: Enhancement
Team: Core
Type: Perf. Defect
Source: Internal
|
run-lab-run |
|
run-ee-tests |
…subsystem [HZ-2702] Introduce a flowControlSequenceNumber into Append/InstallSnapshot requests and responses, to perform matching between them. Added flowControlSequenceNumber to Append/InstallSnapshot requests and responses to perform matching between them. This allows reset the backoff only for the corresponding request. Fix hazelcast#24958
|
run-ee-tests |
|
run-ee-tests |
|
run-ee-tests |
|
The job Click to expand the log file-------------------------- -------TEST FAILURE------- -------------------------- [INFO] Results: [INFO] [ERROR] Failures: [ERROR] FailoverTest.testFailover_clientDoesNotTryMemberListAfterSwitch:330->HazelcastTestSupport.assertTrueAllTheTime:1143->lambda$testFailover_clientDoesNotTryMemberListAfterSwitch$6:331 expected:<3> but was:<4> [ERROR] Errors: [ERROR] PartitionCompactorTest.test_partition_compactor_runs_on_owner_and_backup:82 ? TestTimedOut test timed out after 300000 milliseconds [INFO] [ERROR] Tests run: 11175, Failures: 1, Errors: 1, Skipped: 108 [INFO] |
|
run-ee-tests |
|
run-ee-tests |
1 similar comment
|
run-ee-tests |
vbekiaris
approved these changes
Jul 24, 2023
hazelcast/src/test/java/com/hazelcast/cp/internal/raft/impl/state/FollowerStateTest.java
Outdated
Show resolved
Hide resolved
ahmetmircik
reviewed
Jul 25, 2023
hazelcast/src/main/java/com/hazelcast/cp/internal/raft/impl/state/FollowerState.java
Show resolved
Hide resolved
ahmetmircik
reviewed
Jul 25, 2023
hazelcast/src/main/java/com/hazelcast/cp/internal/raft/impl/dto/AppendFailureResponse.java
Outdated
Show resolved
Hide resolved
ahmetmircik
approved these changes
Jul 25, 2023
|
The job Click to expand the log file-------------------------- -------TEST FAILURE------- -------------------------- [INFO] Results: [INFO] [ERROR] Failures: [ERROR] MemberJmxMetricsTest.testNoMBeanLeak:64 expected:<0> but was:<1> [INFO] [ERROR] Tests run: 4659, Failures: 1, Errors: 0, Skipped: 11 [INFO] [WARNING] Corrupted channel by directly writing to native stream in forked JVM 8. See FAQ web page and the dump file /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder_3/hazelcast/target/surefire-reports/2023-07-25T11-10-53_278-jvmRun8.dumpstream |
|
run-lab-run |
arodionov
added a commit
to arodionov/hazelcast
that referenced
this pull request
Jul 25, 2023
…subsystem [HZ-2702] [5.3.z] (hazelcast#25055) Added `flowControlSequenceNumber` to Append/InstallSnapshot requests and responses to perform matching between them. This allows reset the backoff only for the corresponding request. Fixes hazelcast#24958 Breaking changes (list specific methods/types/messages): * `AppendRequest`, `InstallSnapshot`, `AppendSuccessResponse`,`AppendFailureResponse` (cherry picked from commit 8e3ffce)
6 tasks
arodionov
added a commit
that referenced
this pull request
Jul 26, 2023
…subsystem [HZ-2702] [5.3.z] (#25055) (#25074) Added `flowControlSequenceNumber` to Append/InstallSnapshot requests and responses to perform matching between them. This allows reset the backoff only for the corresponding request. Fixes #24958 Breaking changes (list specific methods/types/messages): * `AppendRequest`, `InstallSnapshot`, `AppendSuccessResponse`,`AppendFailureResponse` (cherry picked from commit 8e3ffce) Backport of: #25055
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
flowControlSequenceNumberto Append/InstallSnapshot requests and responses to perform matching between them.This allows reset the backoff only for the corresponding request.
Fixes #24958
Breaking changes (list specific methods/types/messages):
AppendRequest,InstallSnapshot,AppendSuccessResponse,AppendFailureResponseChecklist:
Team:,Type:,Source:,Module:) and Milestone setAdd to Release NotesorNot Release Notes contentset@Nonnull/@Nullableannotations@sincetags in Javadoc