Support MS SQL in Jdbc SQL connector [HZ-2694]

extensions/mapstore/src/test/java/com/hazelcast/mapstore/mssql/MSSQLGenericMapStoreTest.java

@@ -0,0 +1,42 @@
+/*
+ * Copyright 2023 Hazelcast Inc.
+ *
+ * Licensed under the Hazelcast Community License (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://hazelcast.com/hazelcast-community-license
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.hazelcast.mapstore.mssql;
+
+import com.hazelcast.mapstore.GenericMapStoreTest;
+import com.hazelcast.nio.serialization.genericrecord.GenericRecord;
+import com.hazelcast.test.annotation.NightlyTest;
+import com.hazelcast.test.jdbc.MSSQLDatabaseProvider;
+import com.hazelcast.test.jdbc.MySQLDatabaseProvider;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import java.util.Properties;
+
+import static com.hazelcast.mapstore.GenericMapLoader.DATA_CONNECTION_REF_PROPERTY;
+import static com.hazelcast.mapstore.GenericMapLoader.EXTERNAL_NAME_PROPERTY;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.Assume.assumeFalse;
+
+@Category(NightlyTest.class)
+public class MSSQLGenericMapStoreTest extends GenericMapStoreTest {
+
+    @BeforeClass
+    public static void beforeClass() {
+        initialize(new MSSQLDatabaseProvider());
+    }
+}

hazelcast-sql/src/main/java/com/hazelcast/jet/sql/impl/connector/jdbc/JdbcSqlConnector.java

@@ -553,6 +553,7 @@ private static QueryDataType resolveType(String columnTypeName) {
                 return QueryDataType.TIMESTAMP;
 
             case "TIMESTAMP WITH TIME ZONE":
+            case "DATETIMEOFFSET":
                 return QueryDataType.TIMESTAMP_WITH_TZ_OFFSET_DATE_TIME;
 
             default:

hazelcast-sql/src/test/java/com/hazelcast/jet/sql/impl/connector/jdbc/AllTypesInsertJdbcSqlConnectorTest.java

@@ -37,10 +37,9 @@
 import java.time.LocalTime;
 import java.time.OffsetDateTime;
 import java.time.ZoneOffset;
-import java.util.ArrayList;
 import java.util.Collection;
-import java.util.List;
 
+import static org.assertj.core.util.Lists.newArrayList;
 import static java.util.Arrays.asList;
 
 @RunWith(HazelcastParametrizedRunner.class)
@@ -108,12 +107,8 @@ public void insertRowWithAllTypes() throws Exception {
         execute("INSERT INTO " + mappingName + " VALUES(0, " + sqlValue + ")");
         execute("INSERT INTO " + mappingName + " VALUES(1, ?)", javaValue);
 
-        List<Class<?>> columnTypes = new ArrayList<>();
-        columnTypes.add(Integer.class);
-        columnTypes.add(jdbcValue.getClass());
-
         assertJdbcRowsAnyOrder(tableName,
-                columnTypes,
+                newArrayList(Integer.class, jdbcValue.getClass()),
                 new Row(0, jdbcValue),
                 new Row(1, jdbcValue)
         );

hazelcast-sql/src/test/java/com/hazelcast/jet/sql/impl/connector/jdbc/mssql/MSSQLAllTypesInsertJdbcSqlConnectorTest.java

@@ -36,11 +36,11 @@ public static void beforeClass() {
 
     @Before
     public void setUp() throws Exception {
-        assumeThat(type).describedAs("TIMESTAMP WITH TIME ZONE not supported on MSSQL")
-                .isNotEqualTo("TIMESTAMP WITH TIME ZONE");
-
-
         // MSSQL doesn't support BOOLEAN but BIT can be used instead and, uses FLOAT as 8-byte floating point type
+        // For Float in MSSQL see https://learn.microsoft.com/en-us/sql/t-sql/data-types/float-and-real-transact-sql?view=sql-server-ver16
+        // For BIT in MSSQL see https://learn.microsoft.com/en-us/sql/t-sql/data-types/bit-transact-sql?view=sql-server-ver16
+        // For TIMESTAMP in MSSQL see https://learn.microsoft.com/en-us/previous-versions/sql/sql-server-2005/ms182776(v=sql.90)?redirectedfrom=MSDN
+        // For DATETIMEOFFSET in MSSQL see https://learn.microsoft.com/en-us/sql/t-sql/data-types/datetimeoffset-transact-sql?view=sql-server-ver16
         if (type.equals("BOOLEAN")) {
             type = "BIT";
         }
@@ -50,6 +50,9 @@ public void setUp() throws Exception {
         if (type.equals("TIMESTAMP")) {
             type = "DATETIME";
         }
+        if (type.equals("TIMESTAMP WITH TIME ZONE")) {
+            type = "DATETIMEOFFSET";
+        }
     }
 
-}
+}

hazelcast/src/test/java/com/hazelcast/test/jdbc/MSSQLDatabaseProvider.java

@@ -45,4 +45,10 @@ public void shutdown() {
             container = null;
         }
     }
+
+    @Override
+    public String createSchemaQuery(String schemaName) {
+        return "IF NOT EXISTS (SELECT 0 FROM information_schema.schemata WHERE schema_name = '" + schemaName
+                + "') BEGIN EXEC sp_executesql N'CREATE SCHEMA " + schemaName + "'; END";
+    }
 }

hazelcast/src/test/java/com/hazelcast/test/jdbc/TestDatabaseProvider.java

@@ -85,4 +85,8 @@ default String quote(String[] parts) {
                      .map(part -> '\"' + part.replaceAll("\"", "\"\"") + '\"')
                      .collect(joining("."));
     };
+
+    default String createSchemaQuery(String schemaName) {
+        return "CREATE SCHEMA IF NOT EXISTS " + schemaName;
+    }
 }