Fix [TCP/IP join] members configuration override [HZ-2786]

[orcunc]

This issue is reported by community.

When HZ_NETWORK_JOIN_TCPIP_MEMBERS env variable is set, the TcpIpConfig members field is appended instead of getting replaced

1. Changed the MemberDomConfigProcessor to replace the given value. Added a new test method to test it
2. There were a lot of unnecessary "throws Exception" in the test class. Removed them

Fixes #21272
Jira https://hazelcast.atlassian.net/browse/HZ-2786

Checklist:

• Labels (Team:, Type:, Source:, Module:) and Milestone set
• Label Add to Release Notes or Not Release Notes content set
• Request reviewers if possible

[hz-devops-test]

The job Hazelcast-pr-builder of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file

---------ERRORS-----------
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/internal/config/override/ExternalMemberConfigurationOverrideEnvTest.java:101:82: ',' is not followed by whitespace. [WhitespaceAfter]
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder/hazelcast/src/test/java/com/hazelcast/internal/config/override/ExternalMemberConfigurationOverrideEnvTest.java:101:93: ',' is not followed by whitespace. [WhitespaceAfter]
--------------------------

[hz-devops-test]

The job Hazelcast-pr-compiler of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file

---------ERRORS-----------
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-compiler/hazelcast/src/test/java/com/hazelcast/internal/config/override/ExternalMemberConfigurationOverrideEnvTest.java:101:82: ',' is not followed by whitespace. [WhitespaceAfter]
--------------------------
[ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-compiler/hazelcast/src/test/java/com/hazelcast/internal/config/override/ExternalMemberConfigurationOverrideEnvTest.java:101:93: ',' is not followed by whitespace. [WhitespaceAfter]
--------------------------

[hz-devops-test]

The job Hazelcast-pr-builder of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file

--------------------------
-------TEST FAILURE-------
--------------------------
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   XMLConfigBuilderTest>AbstractConfigBuilderTest.testCompleteAdvancedNetworkConfig:527->HazelcastTestSupport.assertContains:815 Collection [10.10.1.12] (1) didn't contain expected '10.10.1.11'
[INFO] 
[ERROR] Tests run: 54781, Failures: 1, Errors: 0, Skipped: 243
[INFO] 
[ERROR] There are test failures.

[vbekiaris]

I don't think we should change the behaviour of the env variable to overwrite instead of append. Previously, there was an explicit effort to ensure env variables patch an existing config - not overwrite. e.g. see #17878 and related issue #17874.

Maybe the solution is to get rid of the default 127.0.0.1 IP in the members list in hazelcast-docker.xml mentioned in #21272 ?

[orcunc]

There is no direct hazelcast-docker.xml file . I think a hazelcast-default.xml is copied as hazelcast-docker.xml in the distribution/src/assembly/assembly-descriptor.xml file. But I am not sure. I could not understand the build system

Do you think we should delete the line in
hazelcast/src/main/resources/hazelcast-default.xml file ?
Or close this PR without changing anything ?