Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not check order of indexes when MapConfig is added via dynamic configuration #25234

Merged
merged 1 commit into from Aug 22, 2023

Conversation

k-jamroz
Copy link
Collaborator

@k-jamroz k-jamroz commented Aug 16, 2023

Index order generally does not matter. Indexes are matched by name and chosen for the query based on the attributes. MapConfigs with different index order should be treated as equivalent.

Reported via community slack: https://hazelcastcommunity.slack.com/archives/C015Q2TUBKL/p1692188601524379

Checklist:

  • Labels (Team:, Type:, Source:, Module:) and Milestone set
  • Label Add to Release Notes or Not Release Notes content set
  • Request reviewers if possible

Copy link
Collaborator

@vbekiaris vbekiaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix @k-jamroz. Should it be backported to 5.3.z, wdyt?

@k-jamroz
Copy link
Collaborator Author

@vbekiaris I think the issue is rather hard to trigger, you have to be creating MapConfig with unpredictable order of IndexConfigs (eg. from hash map), which looks like not the most obvious way to do it. So I would wait with backporting unless this is explicitly requested.

@k-jamroz k-jamroz merged commit 420ad00 into hazelcast:master Aug 22, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants