Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make
MethodProbe
s useMethodHandle
s over reflection (HZ-3024) #25279Make
MethodProbe
s useMethodHandle
s over reflection (HZ-3024) #25279Changes from 43 commits
4d90beb
0a90cc0
670f19a
0420650
9637a79
14254b6
b89e83b
f93136f
e4af74b
0a86747
799a8ab
80c6c5e
990c185
70c5306
b3e47ad
2dd9a48
b2402b1
67ab6eb
8c7ae5a
6a5e367
5db409e
308068c
6fe9b79
24fc1f0
70379d7
652d05a
d9e54b1
9ffd2df
fb7c291
3feebf6
ba90835
fab31e1
1a02dfd
7cc5136
4cb0077
a00165c
15ca076
fb5db6a
5fccd6f
00afd56
c437190
845a41e
9fd3a03
2c43ac7
943c494
63ce564
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the type system is enriched with the other primitive types, you can use a VarHandle and use the same technique to prevent litter as with the MethodProbe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it already did for some reason.
Raised separately, although a very easy change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the type enrichment can be left for a future PR