-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow MIT-0
Licence
#25325
Allow MIT-0
Licence
#25325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is MIT-0 a valid SPDX identifier?
I created guide to help when updating 3rd party license.
Please check https://hazelcast.atlassian.net/wiki/spaces/EN/pages/4595122178/How+to+fix+Hazelcast+THIRD-PARTY+license+issues
Yes. |
Yes it is. just checked. |
I thought about this, but from what I understood, a merge entry is to help merge aliases of the same licence. As there's only label for MIT-0, there's no point doing that...? |
Sure. np. I was just thinking for the next person tbh. If merge node is there it forces the next person to merge as opposed to possibly add the license to include block directly. We are good for now !! |
The
org.reactivestreams:reactive-streams:1.0.4
transitive dependency uses an MIT-0 licence, which was not specifically allowed in thelicense-maven-plugin
configuration.reactive-streams
has been on MIT-0 for a long time, but only since #25284 - where theS3
client was updated to use newreactive-streams
- has this become a problem.This caused intermittent failures of the PR builder.
This intermittency was presumably caused by the fact that the licence check was recently turned off by default for performance reasons (see comments on the
license.skipAddThirdParty
property).Although the original PR builder execution failed the first time with this error, the second time it passed and was merged - and then caused more PR builder execution failures on other, unrelated PRs.
Unfortunately I don't have a solution on how to prevent this problem in future.
As MIT-0 is a less restrictive version of the MIT licence (which is included), so I've included this also.