Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use consistent serialization service for ByKey plans and simplify assertions [HZ-3128] #25631

Merged
merged 1 commit into from Oct 5, 2023
Merged

Use consistent serialization service for ByKey plans and simplify assertions [HZ-3128] #25631

merged 1 commit into from Oct 5, 2023

Conversation

k-jamroz
Copy link
Collaborator

@k-jamroz k-jamroz commented Oct 5, 2023 •
edited

Correct implementation of sanity checks discussed in #25477 (comment) + fix of uncovered inconsistencies.

Fixes HZ-3128

Checklist:

  • Labels (Team:, Type:, Source:, Module:) and Milestone set
  • Label Add to Release Notes or Not Release Notes content set
  • Request reviewers if possible
  • Send backports/forwardports if fix needs to be applied to past/future releases
  • New public APIs have @Nonnull/@Nullable annotations
  • New public APIs have @since tags in Javadoc

@k-jamroz k-jamroz mentioned this pull request Oct 5, 2023
Merged
@k-jamroz k-jamroz added this to the 5.4.0 milestone Oct 5, 2023
@Fly-Style Fly-Style self-requested a review October 5, 2023 16:11
@Fly-Style Fly-Style merged commit 1710804 into hazelcast:master Oct 5, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fly-Style Fly-Style Fly-Style approved these changes

@ivanthescientist ivanthescientist ivanthescientist approved these changes

Assignees
No one assigned
Labels
Add to Release Notes Module: SQL Source: Internal PR or issue was opened by an employee Team: SQL Type: Enhancement
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@k-jamroz @Fly-Style @ivanthescientist