Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isAsync takes precedence over OperationHostileThread #26227

Closed
wants to merge 1 commit into from
Closed

isAsync takes precedence over OperationHostileThread #26227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...st/src/main/java/com/hazelcast/spi/impl/operationexecutor/impl/OperationExecutorImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,16 +520,16 @@ public boolean isInvocationAllowed(Operation op, boolean isAsync) {

Thread currentThread = Thread.currentThread();

// IO threads are not allowed to run any operation
if (currentThread instanceof OperationHostileThread) {
return false;
}

// if it is async we don't need to check if it is PartitionOperationThread or not
if (isAsync) {
return true;
}

// IO threads are not allowed to run any operation
if (currentThread instanceof OperationHostileThread) {
return false;
}

// allowed to invoke non partition specific task
if (op.getPartitionId() < 0) {
return true;
Expand Down
4 changes: 2 additions & 2 deletions ...elcast/spi/impl/operationexecutor/impl/OperationExecutorImpl_IsInvocationAllowedTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ public Boolean call() throws Exception {
DummyOperationHostileThread hostileThread = new DummyOperationHostileThread(futureTask);
hostileThread.start();

assertEqualsEventually(futureTask, FALSE);
assertEqualsEventually(futureTask, TRUE);
}

// ===================== partition specific operations ========================
Expand Down Expand Up @@ -249,6 +249,6 @@ public Boolean call() throws Exception {
DummyOperationHostileThread thread = new DummyOperationHostileThread(futureTask);
thread.start();

assertEqualsEventually(futureTask, FALSE);
assertEqualsEventually(futureTask, TRUE);
}
}