Makes write-coalescing configurable #4437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmetmircik
force-pushed
the
fix/3.3.5/makeWriteCoalescingConfigurable
branch
from
5eed1b0
to
14597aa
Compare
|
looks good to merge |
| * @return {@code true} if collection is not empty. | ||
| */ | ||
| public static boolean isNotEmpty(Collection collection) { | ||
| return !isEmpty(collection); |
There was a problem hiding this comment.
We probably don't need isNotEmpty since !isEmpty is shorter. Negated version can be created for every boolean method:)
There was a problem hiding this comment.
!yes i think it is more readable :)
|
looks good, I think you will send the changes for maintenance and master branches too ? |
|
@gurbuzali yes |
gurbuzali
pushed a commit
that referenced
this pull request
Jan 19, 2015
…ngConfigurable Makes write-coalescing configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4438
Correct fix to a relevant issue #712