Exposed TcpIpJoiner.MAX_PORT_TRIES as a configurable system property #5175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public TcpIpJoiner(Node node) { | ||
| super(node); | ||
| int tryCount = node.groupProperties.TCP_JOIN_PORT_TRY_COUNT.getInteger(); |
There was a problem hiding this comment.
Probably better to throw an exception here (fail fast).
I think we should give the group properties a good cleanup so that its constrains can be defined in the group property itself instead of dealing with it when you get the property.
GroupProperty<Integer> TRY_COUNT = new GroupProperty<Integer>("com.hazelcast.tcp.tryCount").isPositive(...).build();
We can then move all the property verification out of the code. Another advantage is that it is more obvious to the end user what the constraints of a particular property are.
|
One comment. Apart from that it looks good. |
|
Can be merged once green. |
pveentjer
added a commit
that referenced
this pull request
Apr 28, 2015
Exposed TcpIpJoiner.MAX_PORT_TRIES as a configurable system property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5062