Fixes major bug which makes jclouds discovery unusable. #6651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| location = location.getParent(); | ||
| } | ||
| return true; |
There was a problem hiding this comment.
if location itself or any of its parents in the graph is not in REGION scope, it returns true. That means to me node is not inside that region but method name is isNodeInsideRegions.
It feels strange...
There was a problem hiding this comment.
Yes, it might be feel strange, but a Node in jclouds always has REGION scope, because you cannot define a ComputeResource without binding it to a region or zone. So your case will never happen.
kobalski
force-pushed
the
fix/jclouds_zone_region_bugfix
branch
from
c9a704e
to
8ca3493
Compare
| Properties jcloudsProperties = newOverrideProperties(); | ||
| if (regions != null) { | ||
| List<String> regionList = Arrays.asList(regions.split(",")); | ||
| for (String region : regionList) { | ||
| regionsSet.add(region); |
There was a problem hiding this comment.
so now we are supporting multi regions and zones. (with comma separated) right?
kobalski
force-pushed
the
fix/jclouds_zone_region_bugfix
branch
from
8ca3493
to
6b3656d
Compare
|
Thanks for your comments. Will merge if no more comments are present today. |
|
verify |
3 similar comments
|
verify |
|
verify |
|
verify |
zone and regions filtering current jclouds implementation discovery is broken. Also added more logs and unit tests, configuration for live testing is coming after this pr is merged.
kobalski
force-pushed
the
fix/jclouds_zone_region_bugfix
branch
from
6b3656d
to
4dc3110
Compare
mesutcelik
pushed a commit
that referenced
this pull request
Nov 9, 2015
Fixes major bug which makes jclouds discovery unusable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in zone and regions filtering current jclouds implementation discovery is
broken in 3.6-EA. Also added more logs and unit tests, configuration for live
testing is coming after this pr is merged.