Unit tests for AbstractSerializationService #6775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asimarslan
force-pushed
the
feature/master/serialization-tests
branch
from
4ddb4fc
to
deb24f4
Compare
|
run-lab-run |
|
👍 |
asimarslan
added a commit
that referenced
this pull request
Nov 19, 2015
…-tests Unit tests for AbstractSerializationService
| public void testGlobalRegister_alreadyRegisteredType() throws Exception { | ||
| abstractSerializationService.register(StringBuffer.class, new StringBufferSerializer(true)); | ||
| abstractSerializationService.registerGlobal(new TheOtherGlobalSerializer(true)); | ||
| } |
There was a problem hiding this comment.
I'm not sure why this should throw an exception, the global serializer should be separate from custom serializers, even if it extends the class?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.