Include owner connection to heart beat check #7252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When client is inactive, server needs to close the connection so that resources(e.g locks) associated with that connection can be released. When there are 2 connection from client to server, we did not want to check owner connection since there were no heartbeat send over it. After removing seperate owner connection from the system this check caused a bug. With one connection to each node, all connections needs to be checked and closed. Leaving the check for C++ client until, it's architecture is updated as other clients. Fixes hazelcast#5054
This was referenced Jan 5, 2016
|
verify |
|
👍 (as long as it's only temporary until c++ client is fixed) |
|
you could write a unit test which will fail after some date - as a reminder :))) |
|
Here is the Cpp issue with 3.6.1 milestone |
|
👍 |
sancar
pushed a commit
that referenced
this pull request
Jan 5, 2016
…tBeat/master Include owner connection to heart beat check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When client is inactive, server needs to close the
connection so that resources(e.g locks) associated with that connection
can be released. When there are 2 connection from client to server,
we did not want to check owner connection since there were no
heartbeat send over it.
After removing separate owner connection from the system this check
caused a bug. With one connection to each node, all connections
needs to be checked and closed.
Leaving the check for C++ client until, it's architecture is updated
as other clients.
Fixes #5054