Introducing MemoryAccessor for abstraction on memory access operations
#7515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param field | ||
| * @return | ||
| */ | ||
| long getObjectFieldOffset(Field field); |
There was a problem hiding this comment.
May be should javaDoc here ?
There was a problem hiding this comment.
ah, I have forgotten them
serkan-ozal
force-pushed
the
enhancement/master/introducing-memory-accessor
branch
from
bab4fef
to
b21c67f
Compare
| } | ||
|
|
||
| @Override | ||
| public long getLong(long address) { |
There was a problem hiding this comment.
Where I can point which ENDIAN here ?
serkan-ozal
force-pushed
the
enhancement/master/introducing-memory-accessor
branch
3 times, most recently
from
3597e9f
to
464a1c3
Compare
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
Maybe you can note the reason of deprecation?
|
only minors comments. 👍 |
serkan-ozal
force-pushed
the
enhancement/master/introducing-memory-accessor
branch
from
464a1c3
to
c2a390b
Compare
serkan-ozal
pushed a commit
that referenced
this pull request
Feb 15, 2016
…ing-memory-accessor Introducing `MemoryAccessor` for abstraction on memory access operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MemoryAccessoris a new contact point for accessing memory.MemoryAccessorimplementations areUnsafebased and interprets given addresses as native memory addresses. So these implementations can be thought as direct memory accessors.UnsafeHelperis deprecated and offeredMemoryAccessorinstead.The follow-up task of this PR should be cleaning
Unsafeusages in our code base.