Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes hanging authentication future #7866

Conversation

Projects
None yet
1 participant
@sancar
Copy link
Member

commented Mar 30, 2016

When connection gets exception from socket and destroyConnection
is called before connection is authenticated, client does not
have an endpoint and it is not in connections map. Because of
that closing that connection was missing. I have added close
for that.

Secondly, authentication future was waiting infinite. Since it is
not in connections map, heartbeat does not works on that connection
yet. And we should not have infinite wait on something we can not
detect if heart is beating.

Fixes testMapReduceJobSubmissionWithNoDataNode test which was
failing spuriously.

Fixes hanging authentication future
When connection gets exception from socket and destroyConnection
is called before connection is authenticated, client does not
have an endpoint and it is not in connections map. Because of
that closing that connection was missing. I have added close
for that.

Secondly, authentication future was waiting infinite. Since it is
not in connections map, heartbeat does not works on that connection
yet. And we should not have infinite wait on something we can not
detect if heart is beating.

Fixes testMapReduceJobSubmissionWithNoDataNode test which was
failing spuriously.

@sancar sancar self-assigned this Mar 30, 2016

@sancar sancar added this to the 3.6.3 milestone Mar 30, 2016

sancar added a commit to sancar/hazelcast that referenced this pull request Mar 30, 2016

@sancar sancar referenced this pull request Mar 30, 2016

Merged

Backport of client fixes #7867

@sancar sancar merged commit 4022592 into hazelcast:maintenance-3.x Mar 30, 2016

1 check passed

default 10616 tests run, 39 skipped, 0 failed.
Details

@sancar sancar deleted the sancar:fix/hangingAuthenticationFuture/maint3.x branch Mar 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.