Fixes hanging authentication future #7866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When connection gets exception from socket and destroyConnection is called before connection is authenticated, client does not have an endpoint and it is not in connections map. Because of that closing that connection was missing. I have added close for that. Secondly, authentication future was waiting infinite. Since it is not in connections map, heartbeat does not works on that connection yet. And we should not have infinite wait on something we can not detect if heart is beating. Fixes testMapReduceJobSubmissionWithNoDataNode test which was failing spuriously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connection gets exception from socket and destroyConnection
is called before connection is authenticated, client does not
have an endpoint and it is not in connections map. Because of
that closing that connection was missing. I have added close
for that.
Secondly, authentication future was waiting infinite. Since it is
not in connections map, heartbeat does not works on that connection
yet. And we should not have infinite wait on something we can not
detect if heart is beating.
Fixes testMapReduceJobSubmissionWithNoDataNode test which was
failing spuriously.