Fix a potentially misleading exception message #8738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| if (state == NodeState.SHUT_DOWN) { | ||
| throw new HazelcastInstanceNotActiveException("This node is shut down! Operation: " + op); | ||
| throw new HazelcastInstanceNotActiveException(localMember + " is shut down! Operation: " + op); |
There was a problem hiding this comment.
doesn't this message still contain this? See toString here
There was a problem hiding this comment.
perhaps it's ok to use an address here? wdyt?
|
👍 |
|
Test PASSed. |
Exception can be sent over network hence using "this node" is not great. See hazelcast#8736
jerrinot
force-pushed
the
fixes/node-state-misleading-exception/master
branch
from
209361d
to
4de69e4
Compare
|
@mdogan, @metanet, @ahmetmircik: I changed it to use addresses instead of members. Are you ok with it? |
|
yep |
|
Test PASSed. |
This was referenced Aug 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exception can be sent over network hence using "this node"
is not great.
See #8736