Fix wrong scheduled task count caused by backup replicas #9704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When scheduling tasks on random partitions, the getAllScheduled call returns twice as many futures from the expected result. The reason seems to be the backup replicas which are also returned, even though they are just stashed placeholders having no future scheduled. To address this, we introduced a flag, marking the main copy of the task as master upon initital scheduling or promotions and using that when building the list of tasks to return to the API call
|
Test PASSed. |
|
When there is a migration rolllback then the source side will always set itself as a master replica. is this the right thing to do? |
|
@jerrinot thanks for the comment, but to be honest I can't say I understand the concern :/ |
mmedenjak
reviewed
Jan 20, 2017
| * This flag is set to true only on ititial scheduling of a task, and on after a promotion (stashed or migration), | ||
| * in the latter case the other replicas get disposed. | ||
| */ | ||
| private transient boolean masterReplica; |
There was a problem hiding this comment.
Perhaps for clarity rename to isPartitionOwner since "master" is a different thing in the cluster.
|
@mmedenjak addressed both comments ;) |
mmedenjak
approved these changes
Jan 20, 2017
jerrinot
approved these changes
Jan 20, 2017
|
Test PASSed. |
1 similar comment
|
Test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scheduling tasks on random partitions, the getAllScheduled call
returns twice as many futures from the expected result. The reason
seems to be the backup replicas which are also returned, even though they are
just stashed placeholders having no future scheduled. To address this, we introduced
a flag, marking the main copy of the task as master upon initital scheduling or promotions
and using that when building the list of tasks to return to the API call.
Fixes #9694