Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up dependency management #171

Merged
merged 4 commits into from May 11, 2021
Merged

Conversation

aloubyansky
Copy link
Contributor

Add the deployment artifact to the BOM, remove imports of Quarkus project internal internal POMs (they don't seem to be useful anyway).

@devOpsHazelcast
Copy link
Contributor

devOpsHazelcast commented May 10, 2021

CLA assistant check
All committers have signed the CLA.

@aloubyansky
Copy link
Contributor Author

This looks suspicious https://github.com/hazelcast/quarkus-hazelcast-client/blob/master/runtime/pom.xml#L56 Is there a reason it's not in the BOM? If it represents a runtime classpath requirement it should be added to the BOM.

@pivovarit
Copy link
Contributor

Thanks! Super helpful! Was it supposed to be done like that since the beginning or has something changed along the way?

@aloubyansky
Copy link
Contributor Author

Originally, runtime and deployment dependencies were in their own BOMs in Quarkus. But it's been awhile since they were merged together. For your extension we simply did it in the "universe" BOM. Going forward though, it'd be good to have it right in your original BOM.
Your BOM is also not required to import the quarkus-bom. The way your project is setup though currently, it may actually be useful to keep it for your internal build and tests.

Is the next release coming soon? Thanks!

@pivovarit pivovarit added this to the 1.2.0 milestone May 11, 2021
@pivovarit
Copy link
Contributor

Actually, I was supposed to release today so you were right on time with suggestions!

@aloubyansky
Copy link
Contributor Author

Excellent! If you don't mind, once the release becomes available, please upgrade the version in the Quarkus platform repo and remove https://github.com/quarkusio/quarkus-platform/blob/main/bom/pom.xml#L133-L137. Thanks!

@pivovarit pivovarit merged commit c97e2ae into hazelcast:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants