Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] typing doesn't have Literal #283

Closed
duguyue100 opened this issue Mar 3, 2023 · 4 comments
Closed

[BUG] typing doesn't have Literal #283

duguyue100 opened this issue Mar 3, 2023 · 4 comments

Comments

@duguyue100
Copy link

Describe the bug
A clear and concise description of what the bug is.

https://github.com/HazyResearch/meerkat/blob/main/meerkat/interactive/app/src/lib/component/abstract.py#L7

In this line, the Literal type is imported from typing but typing doesn't have Literal, it should be typing_extensions.
This will result an import error.

@krandiash
Copy link
Contributor

Thanks for the bug report, #286 should address this when it's merged into main. I suggest using Py 3.8+ in the meantime

@krandiash
Copy link
Contributor

Merged into main, you should be able to use it right now with a direct clone + install from main. Otherwise this will be in our next release (which will go out in the next 24 hours).

@ad12
Copy link
Collaborator

ad12 commented Mar 4, 2023

we pushed up the latest patch, which includes this fix:

pip install --upgrade meerkat-ml

@duguyue100
Copy link
Author

Thanks for fixing this! We will definitely try in our next release cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants