Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decompilation issue of constrainded generics #198

Merged
merged 7 commits into from Oct 16, 2022

Conversation

cmeyertons
Copy link
Contributor

Please see the failing test, added another implementation of IPerson and the query start failing. The decompile works appropriately when there is only one implementation of the interface. Otherwise, it creates a weird expression that is doing ternaries on each individual implementation.

@cmeyertons
Copy link
Contributor Author

Alright this is my rough implementation, very open to feedback, but it does resolve the issue.

@hazzik hazzik changed the title Bug: Cannot decompile from an interface with multiple implementations Fix decompilation issue of constrainded generics Oct 16, 2022
@hazzik hazzik merged commit 9b378e4 into hazzik:develop Oct 16, 2022
@hazzik
Copy link
Owner

hazzik commented Oct 17, 2022

This has been released in 0.31.0. Please consider ❤️ supporting the project.

billybraga pushed a commit to billybraga/DelegateDecompiler that referenced this pull request Nov 3, 2023
Fixes hazzik#199 

+semver:fix

Co-authored-by: Alex Zaytsev <hazzik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants