Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color pallate incompatible with right to left aligned languages #9

Closed
Aransh opened this issue Apr 27, 2020 · 2 comments
Closed

Color pallate incompatible with right to left aligned languages #9

Aransh opened this issue Apr 27, 2020 · 2 comments
Assignees
@kirb
Labels
bug Something isn't working
Milestone
1.1

Comments

@Aransh
Copy link

Aransh commented Apr 27, 2020

When using the color pallate (on Scorpion), whichever color I tap will select the color in the mirrored location (as in, tap blue in right edge, get green in left edge selected).
@kirb kirb self-assigned this Apr 30, 2020
@kirb kirb added the bug Something isn't working label Apr 30, 2020
@kirb kirb added this to the 1.1 milestone Apr 30, 2020
@kabiroberai
Copy link
Contributor

This should have been fixed by #3, as I changed it to use hitTest rather than calculating the color itself (see ColorPickerSwatchViewController.swift:249)

@kirb
Copy link
Member

kirb commented Oct 11, 2020

This should be fixed with 1.1. Due to the way I changed the implementation, the palette/swatch will no longer flip right-to-left for RTL languages. I may add RTL support back in a future release.

@kirb kirb closed this as completed Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirb kirb

Labels
bug Something isn't working
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
3 participants
@kirb @Aransh @kabiroberai