Adding library messes up with the activity style & show Toolbar by default

[RahulSDeshpande]

I tried adding your library to my Android project:

implementation("com.hbb20:android-country-picker:0.0.6")

When I run the app, it overrides the activity style & show Toolbar by default!!
I am using style with this theme Theme.MaterialComponents.Light.NoActionBar.

This is the only reason I am not using this library 😞

[github-actions]

I will look into this as soon as I get some time. If it's critical, please contact harshbbhakta@gmail.com

[hbb20]

Do you use material theme or you follow a custom theme?

…

On Wed, Feb 16, 2022 at 22:46 github-actions[bot] ***@***.***> wrote: I will look into this as soon as I get some time. If it's critical, please contact ***@***.*** — Reply to this email directly, view it on GitHub <#45 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABFQ32GUSC6S4HR3ST5F7DLU3SDSBANCNFSM5OTU75XQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[RahulSDeshpande]

I am using Material theme:

<style name="SfAppTheme" parent="Theme.MaterialComponents.Light.NoActionBar">
    ..
</style>

I fixed it, I had to change the style name from AppTheme to some another name, for eg: SfAppTheme.
I found out that your lib AndroidCountryPicker was overriding my app's theme & showing Toolbar by default!! 😞

[hbb20]

Since you have applied the theme to your app that should have precedence over theme defined in any library. Have you applied the defined theme to your entire app (and all its modules)?

…

On Fri, Feb 18, 2022 at 03:29 AndroCurious ***@***.***> wrote: I am using Material theme: <style name="SfAppTheme" parent="Theme.MaterialComponents.Light.NoActionBar"> .. </style> — Reply to this email directly, view it on GitHub <#45 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABFQ32HTI2WH3EQZL2NKHJDU3YNP5ANCNFSM5OTU75XQ> . You are receiving this because you commented.Message ID: ***@***.***>

[RahulSDeshpande]

Exactly, my app's theme should override your lib's theme.
This is strange 😵‍💫

Yes I had applied that theme everywhere.

[hbb20]

I'll take a look at it this weekend. Is there any isolated project that can reproduce this?

…

On Fri, Feb 18, 2022 at 11:04 AndroCurious ***@***.***> wrote: Exactly, my app's theme should override your lib's theme. This is strange 😵‍💫 Yes I had applied that theme everywhere. — Reply to this email directly, view it on GitHub <#45 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABFQ32AFHVCM4UG7RDKMCX3U32CZ5ANCNFSM5OTU75XQ> . You are receiving this because you commented.Message ID: ***@***.***>

[RahulSDeshpande]

I was just exploring the library in one of my private projects.
Sorry it's not open source.

[hbb20]

I created a sample project and kept the theme name "AppTheme" and project's theme overrode the library theme. So not sure why you had to change the theme name. But anyways, it will be a good idea for library to change theme name.

[hbb20]

v0.0.7 should have this fixed if this was a problem by library in the first place.

[RahulSDeshpande]

@hbb20 Cool thanks 🤟🏼
I would suggest you to change the lib theme name by adding some prefix to it, like ACPAppTheme.