Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: statuspage misses callsign #186

Closed
hbeni opened this issue Mar 21, 2024 · 1 comment · Fixed by #178
Closed

Bug: statuspage misses callsign #186

hbeni opened this issue Mar 21, 2024 · 1 comment · Fixed by #178
Assignees
@hbeni
Labels
Bots Affecting bot implementation bug Something isn't working Status Page Affecting the status page implementation

Comments

@hbeni
Copy link
Owner

hbeni commented Mar 21, 2024 •
edited
Loading

Describe the bug
In rare occasions it could happen (due to a client bug?) that remotes do not send a USR packet, thus the callsign is never seen for the affected user.

To Reproduce
Unknown, just had seen that in the statusbot server log accidentally.
But that could in theory always happen.

Expected behavior
Callsign should be displayed always.
For that to happen, the statusbot needs to:

  • detect that expected client data is missing
  • wait some time if the situation resolves (for example at init time it can take some time)
  • If it does not resolve, ask the client in question for data via a ICANHAZDATAPLZ packet (and reset a detection flag)

(Related to issue #174 / PR #178)
@hbeni hbeni added bug Something isn't working Bots Affecting bot implementation Status Page Affecting the status page implementation labels Mar 21, 2024
@hbeni hbeni self-assigned this Mar 21, 2024
@hbeni hbeni linked a pull request Mar 21, 2024 that will close this issue
Bots and statuspage fixes #178
Merged
@hbeni
Copy link
Owner Author

hbeni commented Mar 21, 2024

Will be resolved by #178 (a42a9d8)

@hbeni hbeni mentioned this issue Mar 21, 2024
Merged
@hbeni hbeni closed this as completed in #178 Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hbeni hbeni

Labels
Bots Affecting bot implementation bug Something isn't working Status Page Affecting the status page implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bots and statuspage fixes hbeni/fgcom-mumble
1 participant
@hbeni